Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure etcd and kube-proxy metrics to listen on minikube node IP #6322

Merged
merged 2 commits into from
Jan 29, 2020

Conversation

chancez
Copy link
Member

@chancez chancez commented Jan 15, 2020

Configures etcd and kube-proxy to expose their metrics on the minikube node IP
instead of localhost so that their metrics can be scraped by Prometheus.

Metrics are already exposed for other control plane services such as kube
apiserver, controller-manager, and scheduler, this simply updates etcd and
kube-proxy to match.

This is desirable so that Prometheus monitoring works within minikube.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chancez
To complete the pull request process, please assign priyawadhwa
You can assign the PR to them by writing /assign @priyawadhwa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2020
@chancez
Copy link
Member Author

chancez commented Jan 15, 2020

/assign @priyawadhwa

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 15, 2020
@codecov-io
Copy link

Codecov Report

Merging #6322 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6322   +/-   ##
=======================================
  Coverage   38.23%   38.23%           
=======================================
  Files         123      123           
  Lines        8269     8269           
=======================================
  Hits         3162     3162           
  Misses       4696     4696           
  Partials      411      411

@tstromberg
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 15, 2020
@minikube-bot
Copy link
Collaborator

Error: running mkcmp
2020/01/15 22:26:49 Executing run 1/3...
2020/01/15 22:26:49 Running: [/home/performance-monitor/minikube/out/minikube start]...
2020/01/15 22:26:49 0.394811: * minikube v1.7.0-beta.0 on Debian 9.11
2020/01/15 22:26:49 0.062144: * Selecting 'kvm2' driver from user configuration (alternates: [none docker])
! Unable to update kvm2 driver: download failed: https://github.com/kubernetes/minikube/releases/download/v1.7.0-beta.0/docker-machine-driver-kvm2?checksum=file:https://github.com/kubernetes/minikube/releases/download/v1.7.0-beta.0/docker-machine-driver-kvm2.sha256: invalid checksum: Error downloading checksum file: bad response code: 404
2020/01/15 22:26:50 0.417521: * Downloading driver docker-machine-driver-kvm2:
> minikube-v1.7.0-beta.0.iso.sha256: 65 B / 65 B [-------] 100.00% ? p/s 0s > minikube-v1.7.0-beta.0.iso: 37.39 MiB / 150.92 MiB [->] 24.77% ? p/s ? > minikube-v1.7.0-beta.0.iso: 72.00 MiB / 150.92 MiB [-->] 47.71% ? p/s ? > minikube-v1.7.0-beta.0.iso: 103.08 MiB / 150.92 MiB [-->] 68.30% ? p/s ? > minikube-v1.7.0-beta.0.iso: 118.66 MiB / 150.92 MiB 78.62% 135.43 MiB p/ > minikube-v1.7.0-beta.0.iso: 150.92 MiB / 150.92 MiB 100.00% 214.86 MiB p2020/01/15 22:26:51 1.611700: * Downloading VM boot image ...
*
X Unable to start VM. Please investigate and run 'minikube delete' if possible

  • Error: [KVM2_NOT_FOUND] new host: Driver "kvm2" not found. Do you have the plugin binary "docker-machine-driver-kvm2" accessible in your PATH?
  • Suggestion: Please install the minikube kvm2 VM driver, or select an alternative --vm-driver
  • Documentation: https://minikube.sigs.k8s.io/docs/reference/drivers/kvm2/
    : exit status 1

@medyagh
Copy link
Member

medyagh commented Jan 15, 2020

the ingress integraiton tests seems to be broken across all ... could it be realted?

@chancez
Copy link
Member Author

chancez commented Jan 16, 2020

I see registry failing in hyperkit and ingress failing in kvm in the CI. It's possible this change is creating an invalid config or something. I'll run integration tests locally and see what I can find.

@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@kubernetes kubernetes deleted a comment from minikube-bot Jan 17, 2020
@kubernetes kubernetes deleted a comment from minikube-bot Jan 17, 2020
@tstromberg
Copy link
Contributor

/ok-to-test

Copy link

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried

curl http://$(minikube ip):2381/metrics

and it worked. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants