-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hyperv: Check for Get-Wmiobject err before parsing output #7867
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
kvm2 Driver |
kvm2 Driver Times for Minikube (PR 7867): [65.264037659 66.926832696 64.172406678] Averages Time Per Log
docker Driver Times for Minikube (PR 7867): [26.969211379 29.477531361 25.979742795] Averages Time Per Log
|
Right after I merged #7790 I realized the PR didn't check for err first.
Also, update the error message handling because Get-Wmiobject only returns an error if it's unavailable to make a local RPC, rather than if the object is not found. Proof that this PR works, in lieu of working Hyper-V integration tests: