Remove misleading and ugly kubectl parameters #9193
Conversation
Chances are users want something more than "get pods" Running the bare command will show some usage info
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XS
| @@ -413,7 +413,7 @@ func showKubectlInfo(kcs *kubeconfig.Settings, k8sVersion string, machineName st | |||
|
|
|||
| path, err := exec.LookPath("kubectl") | |||
| if err != nil { | |||
| out.T(style.Tip, "kubectl not found. If you need it, try: 'minikube kubectl -- get pods -A'") | |||
| out.T(style.Tip, "kubectl not found. If you need it, try: 'minikube kubectl --'") | |||
There was a problem hiding this comment.
Personally, given the strange syntax, I don't feel like this is obvious enough. I wanted to give an example that a user is likely to understand without consulting additional documentation.
There was a problem hiding this comment.
Maybe 'minikube kubectl -- help'?
There was a problem hiding this comment.
Beauty, as they say, is in the eye of the beholder. Maybe I should have used a different word (than ugly).
Did you know that kubectl, kubectl --help and kubectl help all have the same output, by the way ?
I like "help" as an improvement (over "get"), but it wasn't really what I meant.
Maybe I will just close this PR, it was just the new screenshot that caused it.
It looked a bit like an error, while it is perfectly normal. But maybe we want to avoid "other solutions" like:
Command 'kubectl' not found, but can be installed with:
sudo snap install kubectl
It just seemed weird to give an example command, rather than show how to "install" it (e.g. as an alias).
|
Here is how it looked in bash, for reference.
|
Chances are users want something more than "get pods"
💡 kubectl not found. If you need it, try: 'minikube kubectl -- get pods -A'Running the bare command will show some usage info
It looks a bit ugly in the new screen shot, in my opinion
Also helps a bit on the way to making an alias: #7289