Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve release process #874

Closed
wangzhen127 opened this issue Mar 5, 2024 · 6 comments
Closed

Improve release process #874

wangzhen127 opened this issue Mar 5, 2024 · 6 comments

Comments

@wangzhen127
Copy link
Member

Currently the release process is very manual. And only @Random-Liu can run make push. We should simplify the release process.

CC @Random-Liu @vteratipally @hakman

@wangzhen127
Copy link
Member Author

Discussed with @BenTheElder offline. The main pain point of pushing and pulling from gs://kubernetes-release can be removed by just using the github.com file hosting in release notes. Since we already upload tar files in release notes, this would be a simple change.

See kubernetes/kubernetes#123741

@hakman
Copy link
Member

hakman commented Mar 6, 2024

@wangzhen127 We can also promote binaries, like we do for kOps to the bucket (via k8s.io repo) and just link them in release notes.
Ref: kubernetes/k8s.io#6368

@wangzhen127
Copy link
Member Author

That's also fine. But using the github hosting file is the simplest way for now.

Does your organization set up NPD as system daemon of daemonset? So far, cluster/gce/gci/configure.sh is the only place setting it up as system daemon as far as I know. Given kube-up.sh will switch to kops in the future, and kops decides to treat NPD as addons, it may not worth the effort to set up pipelines to promote binaries.

@hakman
Copy link
Member

hakman commented Mar 6, 2024

I am fine with images at the moment.
kOps already has NPD as an addon 😄 . See kubernetes/kops#11381.
We should update the NPD tests to run via kOps in the near future.

@wangzhen127
Copy link
Member Author

wangzhen127 commented Mar 9, 2024

Just realized a few things

  • NPD releases tar files to gs://kubernetes-release/node-problem-detector/ historically. No one has permission to push files to it now. We only have tar files up to v0.8.10 in the GCS bucket.
  • Currently k/k's default NPD version is:
  • NPD's standalone mode configuration in k/k depends on the tar files in the above GCS bucket. Given none of k/k's release blocking tests fail, we already lost the test coverage for about half a year (for both k/k 1.29 and 1.30). I filed Missing test coverage for standalone mode configuration #878 for tracking separately.

For the release process, we should stop pushing tar files to gs://kubernetes-release/node-problem-detector/. We lost push permission for a long time already. Relying on github file hosting should be fine for k/k.

wangzhen127 added a commit to wangzhen127/node-problem-detector that referenced this issue Mar 9, 2024
The release process and `make push` pushes the tar files to
gs://kubernetes-release historically. No one has write permission to the
GCS bucket anymore. We haven't pushed NPD tar files to that GCS bucket
after v0.8.10. k/k has been using NPD v0.8.13+ since 1.29.

This PR cleans up the Make file. NPD release should just include the tar
files in the release note.

Related issues:
- kubernetes#874
- kubernetes#878
wangzhen127 added a commit to wangzhen127/node-problem-detector that referenced this issue Mar 9, 2024
The release process and `make push` pushes the tar files to
`gs://kubernetes-release` historically. No one has write permission to the
GCS bucket anymore. We haven't pushed NPD tar files to that GCS bucket
after v0.8.10. k/k has been using NPD v0.8.13+ since 1.29.

This PR cleans up the Make file. NPD release should just include the tar
files in the release note.

Related issues:
- kubernetes#874
- kubernetes#878
wangzhen127 added a commit to wangzhen127/node-problem-detector that referenced this issue Mar 9, 2024
The release process and `make push` pushes the tar files to
`gs://kubernetes-release` historically. No one has write permission to the
GCS bucket anymore. We haven't pushed NPD tar files to that GCS bucket
after v0.8.10. k/k has been using NPD v0.8.13+ since 1.29.

This PR cleans up the Make file. NPD release should just include the tar
files in the release note.

Related issues:
- kubernetes#874
- kubernetes#878
@wangzhen127
Copy link
Member Author

I have removed the need of pushing tar files to gs://kubernetes-release during release. So any approvers should be able to make the release now. It is still a manual process. But given the low frequency of NPD releases. I can live with it for now. We can revisit if situations change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants