Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove push-tar" #882

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Revert "Remove push-tar" #882

merged 1 commit into from
Mar 11, 2024

Conversation

wangzhen127
Copy link
Member

@wangzhen127 wangzhen127 commented Mar 10, 2024 •
edited

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 10, 2024
@wangzhen127
Copy link
Member Author

/assign @hakman

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 10, 2024
@wangzhen127
Copy link
Member Author

/test pull-npd-e2e-kubernetes-gce-gci

@wangzhen127
Copy link
Member Author

Looks like the presubmit pull-npd-e2e-kubernetes-gce-gci is actually triggered. It does not show up in the summary in the PR. We can see it here: https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/pull-npd-e2e-kubernetes-gce-gci

@wangzhen127
Copy link
Member Author

pull-npd-e2e-kubernetes-gce-gci passed at https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/node-problem-detector/882/pull-npd-e2e-kubernetes-gce-gci/1766915906216136704

@wangzhen127 wangzhen127 mentioned this pull request Mar 10, 2024
Open
@wangzhen127
Copy link
Member Author

/test pull-npd-e2e-kubernetes-gce-gci-custom-flags
/test pull-npd-e2e-kubernetes-gce-ubuntu
/test pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags

@hakman
Copy link
Member

hakman commented Mar 11, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 58211f1 into master Mar 11, 2024
7 checks passed
@wangzhen127 wangzhen127 deleted the revert-880-update-make-push branch March 11, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wangzhen127 @hakman @k8s-ci-robot