Vendor the "right" fsnotify #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #7 |
|
@freeformz IIUC, this should eliminate the dependency on |
added 3 commits
May 26, 2016 15:55
This is the version that hpcloud/tail vendors
The version of fsnotify that is vendored doesn't use it.
|
@Random-Liu done. |
|
@freeformz Quick question. I'm not quite familiar with Godeps. Could you explain the last 2 commits a bit? The first 2 LGTM. |
|
All right, understood the 3rd one. https://github.com/tools/godep/blob/master/Changelog.md |
|
Before v71 we didn't preserve permissions of the files copied in, now we do. This is particularly important for executable files. The last one doesn't really matter that much, it looks like a more exact tag was added at some point and we're now picking it up. |
|
@freeformz Thanks a lot! LGTM! |
Random-Liu
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the version that hpcloud/tail vendors