Generalize the kernel monitor code. #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Random-Liu
force-pushed
the
generalize-log-monitor-code-name
branch
3 times, most recently
from
4d3bbf1
to
903d8db
Compare
This was referenced Feb 8, 2017
Random-Liu
force-pushed
the
generalize-log-monitor-code-name
branch
2 times, most recently
from
6a8f735
to
177a77c
Compare
|
I reviewed two commits 1) Change kernel specific name in code base and change syslog to filelog Meanwhile, should we update README that node-problem-detector can also run as a standalone daemon now? I am ok with another pr. |
|
Please rebase it, and we are ready to merge. |
Random-Liu
force-pushed
the
generalize-log-monitor-code-name
branch
from
177a77c
to
dba47bd
Compare
|
Apply LGTM based on #92 (comment). Will merge this after test passed. |
Actually, @andyxning updated the README.md before https://github.com/kubernetes/node-problem-detector#start-standalone But yes, we should put more information there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #44.
Based on #81 and #88.
his PR:
syslogtofilelog, because actually it does not only support syslog now, it should be able to support most file based logs./cc @dchen1107 @kubernetes/node-problem-detector-reviewers
This change is