-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple system log monitor support #94
Add multiple system log monitor support #94
Conversation
3591c8a
to
835e01f
Compare
835e01f
to
6170b0c
Compare
@dchen1107 Rebased. PTAL. |
I only reviewed one commit (Add multiple log monitoring support) in this pr since all other should be covered / merged through different pr. Two comments I have:
|
Will do.
I manually tested this, and this works. I'll add a test case in NPD e2e test for this feature. |
@dchen1107 Add a new commit to test goroutine leak. In fact, with the unit test, we are still not sure whether a failed log monitor will leak any other resources instead of goroutine. However, resource leaking is originally hard to capture in unit test. |
51c1f60
to
889d9ef
Compare
@dchen1107 The PR is ready for another review. PTAL! |
LGTM |
For #44.
Based on #81, #88 and #92.
Only the last commit is new.
This PR change the
--log-monitor
flag to--log-monitors
. Multiple log monitor config separated by comma can be passed through--log-monitors
, NPD will start a separate log monitor for each of them.This makes it possible to use NPD to monitor different system log at the same time.
/cc @dchen1107 @kubernetes/node-problem-detector-reviewers
This change is![Reviewable](https://camo.githubusercontent.com/2d899f4291d07d3cd2fa4aaae1e3b243f164c23fce87d30a589ace0d496a444c/68747470733a2f2f72657669657761626c652e6b756265726e657465732e696f2f7265766965775f627574746f6e2e737667)