Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reference docs permissions #2002

Merged
merged 1 commit into from Jul 9, 2020
Merged

Update reference docs permissions #2002

merged 1 commit into from Jul 9, 2020

Conversation

zacharysarah
Copy link

This PR updates repo admins to the current roster of SIG Docs chairs.

Related: https://github.com/kubernetes-sigs/reference-docs/pull/162/files#r451224287

/cc @jimangel @kbarnard10

/sig docs
/priority important-soon

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/github-management Issues or PRs related to GitHub Management subproject labels Jul 8, 2020
@zacharysarah
Copy link
Author

Mentioning kubernetes/website#18117 for future reference because this slipped past us during the transition.

@nikhita
Copy link
Member

nikhita commented Jul 8, 2020

@zacharysarah Can we move the SIG Docs related teams to a sig-docs directory here - https://github.com/kubernetes/org/tree/master/config/kubernetes-sigs?

That way you should be able to approve changes to these teams directly. 😄

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2020
@zacharysarah zacharysarah force-pushed the update-permissions branch 2 times, most recently from 7782da7 to dc395f0 Compare July 8, 2020 20:14
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2020
@zacharysarah
Copy link
Author

@nikhita 👋 Ready for review!

nikhita
nikhita approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙇‍♀️

/lgtm
/approve

/hold
wasn't sure if you wanted 👀 from sig docs folks, but please feel free to cancel the hold when you are ready :)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2020
@nikhita
Copy link
Member

nikhita commented Jul 8, 2020

The following members of team reference-docs-maintainers are not Kubernetes SIGs org members: onlydole, sftim

@zacharysarah can you add both of them to @kubernetes-sigs? They are already @kubernetes org members so should be fine to add them directly. :)

@jimangel
Copy link
Member

jimangel commented Jul 8, 2020

/lgtm
Thanks for the update @zacharysarah 🎉

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2020
@zacharysarah
Copy link
Author

@nikhita Ready for review again!

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2020
@nikhita
Copy link
Member

nikhita commented Jul 9, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit d8cc154 into kubernetes:master Jul 9, 2020
@zacharysarah zacharysarah deleted the update-permissions branch September 10, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita approved these changes

@jimangel jimangel Awaiting requested review from jimangel

@kbarnard10 kbarnard10 Awaiting requested review from kbarnard10

Assignees

@jimangel jimangel

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zacharysarah @nikhita @k8s-ci-robot @jimangel