Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add saschagrunert and alejandrox1 as SIG Release admins #2012

Merged
merged 1 commit into from Jul 11, 2020
Merged

Add saschagrunert and alejandrox1 as SIG Release admins #2012

merged 1 commit into from Jul 11, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jul 10, 2020 •
edited

To fulfill the role as new technical lead we need to be part of the SIG
release admin role.

Ref: kubernetes/community#4867

/assign @kubernetes/sig-release-admins
/cc @kubernetes/sig-release

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/github-management Issues or PRs related to GitHub Management subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jul 10, 2020
@saschagrunert saschagrunert mentioned this pull request Jul 10, 2020
Merged
@saschagrunert saschagrunert force-pushed the sig-release-admin branch 2 times, most recently from b9ac996 to f1a77f1 Compare July 10, 2020 09:22
@saschagrunert
Add saschagrunert and alejandrox1 as SIG Release admins
ff75f8d 
To fulfill the role as new technical lead we need to be part of the SIG
release admin role.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert saschagrunert changed the title Add saschagrunert as SIG Release admin Add saschagrunert and alejandrox1 as SIG Release admins Jul 10, 2020
cpanato
cpanato approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2020
hasheddan
hasheddan approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@justaugustus
Copy link
Member

/lgtm
/approve

spiffxp
spiffxp approved these changes Jul 11, 2020
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hasheddan, justaugustus, saschagrunert, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit 59a3338 into kubernetes:master Jul 11, 2020
@saschagrunert saschagrunert deleted the sig-release-admin branch July 11, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@cpanato cpanato cpanato approved these changes

@hasheddan hasheddan hasheddan approved these changes

Assignees

@spiffxp spiffxp

@justaugustus justaugustus

@cpanato cpanato

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@saschagrunert @justaugustus @k8s-ci-robot @spiffxp @cpanato @hasheddan