Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org dependencies #335

Merged
merged 3 commits into from
Jan 8, 2019
Merged

Bump org dependencies #335

merged 3 commits into from
Jan 8, 2019

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented Jan 7, 2019

Update WORKSPACE and dep dependencies for k8s.io/org. This will bring in some peribolos fixes.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 7, 2019
@fejta
Copy link
Contributor

fejta commented Jan 7, 2019

How would you feel about my getting this to work with go modules instead (and possibly deleting the vendor dir in the process)?

@cblecker
Copy link
Member Author

cblecker commented Jan 8, 2019

@fejta This is passing tests now. I'd be totally down with moving to go modules, but this may be complicated with the transitive dependencies on client-go.

I'd still like to get this bump into get the peribolos bug fixes in, and not block my work on peribolos for teams :)

@fejta
Copy link
Contributor

fejta commented Jan 8, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2019
@cblecker
Copy link
Member Author

cblecker commented Jan 8, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit 74275d4 into kubernetes:master Jan 8, 2019
@cblecker cblecker deleted the bump-deps branch January 8, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants