New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org dependencies #335

Merged
merged 3 commits into from Jan 8, 2019

Conversation

Projects
None yet
3 participants
@cblecker
Copy link
Member

cblecker commented Jan 7, 2019

Update WORKSPACE and dep dependencies for k8s.io/org. This will bring in some peribolos fixes.

@fejta

This comment has been minimized.

Copy link
Contributor

fejta commented Jan 7, 2019

How would you feel about my getting this to work with go modules instead (and possibly deleting the vendor dir in the process)?

cblecker added some commits Jan 8, 2019

@cblecker cblecker force-pushed the cblecker:bump-deps branch from 60862a9 to 98a092f Jan 8, 2019

@cblecker cblecker removed the request for review from calebamiles Jan 8, 2019

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jan 8, 2019

@fejta This is passing tests now. I'd be totally down with moving to go modules, but this may be complicated with the transitive dependencies on client-go.

I'd still like to get this bump into get the peribolos bug fixes in, and not block my work on peribolos for teams :)

@fejta

This comment has been minimized.

Copy link
Contributor

fejta commented Jan 8, 2019

/lgtm

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jan 8, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 74275d4 into kubernetes:master Jan 8, 2019

4 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-org-test-all Job succeeded.
Details
pull-org-verify-all Job succeeded.
Details
tide In merge pool.
Details

@cblecker cblecker deleted the cblecker:bump-deps branch Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment