Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unneeded teams #797

Merged
merged 3 commits into from May 9, 2019

Conversation

@cblecker
Copy link
Member

commented May 7, 2019

  • Remove @kubernetes/examples-reviewers: it contains one person, that person is already a maintainer, and it doesn't provide any permissions.
  • Remove @kubernetes/kubernetes-reviewers: team provides no additional access, and isn't useful for mentioning.
  • Remove @kubernetes/kubernetes-admins: All members of this group still have write access via kubernetes-maintainers, and admin access shouldn't be needed -- releases are cut by kubernetes-release-managers.

/cc @kubernetes/owners
/hold

cblecker added some commits May 7, 2019

@k8s-ci-robot k8s-ci-robot requested a review from kubernetes/owners May 7, 2019

@nikhita

nikhita approved these changes May 7, 2019

Copy link
Member

left a comment

/lgtm

@justaugustus

This comment has been minimized.

Copy link
Member

commented May 7, 2019

/lgtm
/approve

@idvoretskyi
Copy link
Member

left a comment

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, idvoretskyi, justaugustus, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp

This comment has been minimized.

Copy link
Member

commented May 7, 2019

/lgtm

@idvoretskyi

This comment has been minimized.

Copy link
Member

commented May 8, 2019

@cblecker anything that blocks us from merging?

@cblecker

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit df9e3bb into kubernetes:master May 9, 2019

4 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-org-test-all Job succeeded.
Details
pull-org-verify-all Job succeeded.
Details
tide In merge pool.
Details

@cblecker cblecker deleted the cblecker:team-changes branch May 9, 2019

@lavalamp

This comment has been minimized.

Copy link
Member

commented May 9, 2019

This locked me out of merging to the rate-limiting feature branch.

@cblecker

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

@lavalamp Do tests not pass on that branch?

@lavalamp

This comment has been minimized.

Copy link
Member

commented May 9, 2019

They pass at the moment. The issue is kubernetes/test-infra#12303 effectively prevents merging master back into the branch.

@cblecker

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

Ohhhh, okay I get it. Working on solution..

@lavalamp

This comment has been minimized.

Copy link
Member

commented May 9, 2019

The solution we have at the moment is kubernetes/kubernetes#77652 but that prevents merging the feature branch back into master...

Also, I think there's no way now to create feature branches?

@lavalamp

This comment has been minimized.

Copy link
Member

commented May 9, 2019

(previously I just did that)

@cblecker

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

@lavalamp I just opened #804 to create a group to delegate this permission to you. We should figure out better solutions to these, but I don't want to block active work.

@lavalamp

This comment has been minimized.

Copy link
Member

commented May 9, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.