Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce geranos concurrency #163

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Conversation

BenTheElder
Copy link
Member

xref #153

this is a quick patch, it's not the end-game.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 8, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 8, 2023
@BenTheElder
Copy link
Member Author

/retest

@BenTheElder
Copy link
Member Author

we can avoid a lot of API calls by keeping an index, but speed is not maximally urgent here and this is the smallest diff. I think this value will be sufficient but we can iterate.

@dims
Copy link
Member

dims commented Mar 8, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ae23681 into kubernetes:main Mar 8, 2023
@BenTheElder BenTheElder deleted the limit-hotfix branch March 8, 2023 23:32
@BenTheElder
Copy link
Member Author

triggered a rerun https://prow.k8s.io/?job=*s3*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants