-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to build a patch release without building a Beta #154
Comments
And even if they are identical, it pushes them separately, which makes it take more time. So there is definitely some time to be saved by being able to only build one release. |
This is by (original) design. It's possible to skip the beta builds in those cases, but we'd have to turn off the consumers too. I believe GKE has some automated rollouts and expect there to be a beta.0 when a new X.Y.Z official release is cut. @alex-mohr @roberthbailey |
1.4.4-beta.0 is a tag that we apply immediately after cutting a 1.4.3 release. This keeps the semantic name on the 1.4 release branch when testing CI builds ahead of 1.4.3 so that everything being tested at that point follows the correct semantic versioning rules. AFAIK it's just a tag applied to git which takes no extra time. |
I think @jessfraz said that the release script pushes the patch release and beta release separately. I might be mis-remembering though. |
It builds the artifacts and pushes them to gcr and gcs for both the major On Sun, Oct 16, 2016 at 10:55 PM, David Oppenheimer <
|
That must have changed with the release automation. |
@roberthbailey the betas have always been pushed at the same time as the official. |
So again, this is a very simple change on the release side. The issue is making sure we're not breaking anyone. |
Closing this. There is the larger issue of what downstream (GKE) expects before anything can happen with this task. |
@ihmccreery Can you add some context here? I remember one time before the automation (anago), we didn't push one of these tagged (but unreleased) releases and something fell over. What was that again and is that still the case today? |
@jessfraz noticed when building 1.4.3 that the release scripts also built a 1.4.4-beta0. Assuming that building the beta slows down the overall process (i.e. these are not completely identical), it would be good to have a "fast" mode that skips the beta when you're in a rush.
cc/ @janetkuo
The text was updated successfully, but these errors were encountered: