Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to build a patch release without building a Beta #154

Closed
davidopp opened this issue Oct 16, 2016 · 10 comments
Closed

Make it possible to build a patch release without building a Beta #154

davidopp opened this issue Oct 16, 2016 · 10 comments
Assignees
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject priority/P3 sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@davidopp
Copy link
Member

@jessfraz noticed when building 1.4.3 that the release scripts also built a 1.4.4-beta0. Assuming that building the beta slows down the overall process (i.e. these are not completely identical), it would be good to have a "fast" mode that skips the beta when you're in a rush.

cc/ @janetkuo

@davidopp
Copy link
Member Author

And even if they are identical, it pushes them separately, which makes it take more time. So there is definitely some time to be saved by being able to only build one release.

@david-mcmahon
Copy link
Contributor

This is by (original) design. It's possible to skip the beta builds in those cases, but we'd have to turn off the consumers too. I believe GKE has some automated rollouts and expect there to be a beta.0 when a new X.Y.Z official release is cut. @alex-mohr @roberthbailey

@roberthbailey
Copy link
Contributor

1.4.4-beta.0 is a tag that we apply immediately after cutting a 1.4.3 release. This keeps the semantic name on the 1.4 release branch when testing CI builds ahead of 1.4.3 so that everything being tested at that point follows the correct semantic versioning rules. AFAIK it's just a tag applied to git which takes no extra time.

@zmerlynn

@davidopp
Copy link
Member Author

I think @jessfraz said that the release script pushes the patch release and beta release separately. I might be mis-remembering though.

@jessfraz
Copy link
Contributor

jessfraz commented Oct 17, 2016

It builds the artifacts and pushes them to gcr and gcs for both the major
release and the beta.

On Sun, Oct 16, 2016 at 10:55 PM, David Oppenheimer <
notifications@github.com> wrote:

I think @jessfraz https://github.com/jessfraz said that the release
script pushes the patch release and beta release separately. I might be
mis-remembering though.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#154 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbAK2dPsdur1aSyKksuaQDpFT7WXgks5q0w3TgaJpZM4KX6x1
.

@roberthbailey
Copy link
Contributor

That must have changed with the release automation.

@david-mcmahon
Copy link
Contributor

@roberthbailey the betas have always been pushed at the same time as the official.
Before the automation was in place and I was still doing things manually, I forgot to push a beta once and got a stern talking to from Ike. Apparently it broke the GKE CI. I don't know if that requirement is still in place, but if not we certainly could skip building and publishing betas.

@david-mcmahon david-mcmahon self-assigned this Oct 22, 2016
@david-mcmahon
Copy link
Contributor

So again, this is a very simple change on the release side. The issue is making sure we're not breaking anyone.

@david-mcmahon
Copy link
Contributor

Closing this. There is the larger issue of what downstream (GKE) expects before anything can happen with this task.

@david-mcmahon
Copy link
Contributor

@ihmccreery Can you add some context here? I remember one time before the automation (anago), we didn't push one of these tagged (but unreleased) releases and something fell over. What was that again and is that still the case today?

@justaugustus justaugustus added sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject priority/P3 sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

5 participants