New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix changelog generation for anago usage #1058
Conversation
saschagrunert
commented
Feb 4, 2020
- We now use the branch specified from anago to not assume a release branch in any case.
- The tag does not exist when generating the notes, so we have to use the HEAD as end rev and the latest tag as start rev.
- If we're not on a release branch, we also do not touch the CHANGELOG-x.y.md files of other releases
- When start or end sha is provided, we do not discover them any more
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert: Adding label: Reasons for blocking this PR:[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.] Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
/test pull-release-cluster-up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, hasheddan, justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This one looks like it's going to get stuck on line 322 again... |