Fix gcbmgr cloudbuild clone step with https remote

[hasheddan]

Signed-off-by: hasheddan georgedanielmangum@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes bug introduced by #1103 that causes cloudbuild clone step to fail cloning release repo.

Which issue(s) this PR fixes:

Ref #1103
Slack Conversation: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1582034517113800

Special notes for your reviewer:

I have opted to be additive with the variables used here due to the fact that RELEASE_TOOL_REPO and RELEASE_TOOL_BRANCH get passed to anago for the same gitlib::repo_state check. However, I would be happy to also update gitlib::repo_state with the new vars and eliminate usage of the two aforementioned ones if that is more desirable :)

Does this PR introduce a user-facing change?:

NONE

/cc @justaugustus @cpanato @saschagrunert

[k8s-ci-robot]

@hasheddan: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.]

• gcb/release/cloudbuild.yaml

• gcb/stage/cloudbuild.yaml

• gcbmgr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[justaugustus]

@hasheddan --

However, I would be happy to also update gitlib::repo_state with the new vars and eliminate usage of the two aforementioned ones if that is more desirable :)

Let's do this. Being additive here is asking for misinterpretation/misuse.
/hold

[justaugustus]

This is looking good on GCB now.

Compare current test run execution details:

User substitutions
_TOOL_BRANCH
fixgcb
_NOMOCK_TAG
_TOOL_REPO
release
_RC
_OFFICIAL
_GCP_USER_TAG
stephen-k8s-at-agst.us
_RC_TAG
_RELEASE_BRANCH
release-1.15
_GIT_TAG
12345
_OFFICIAL_TAG
_BUILD_POINT
v1.15.11-beta.0.1-3b43c8064a328d
_KUBE_CROSS_VERSION
v1.12.12-1
_BUILD_AT_HEAD
_NOMOCK
_TOOL_ORG
hasheddan
_BUILDVERSION
--buildversion=v1.15.11-beta.0.1+3b43c8064a328d

with the previous failure:

User substitutions
_GCP_USER_TAG
ctadeu-at-gmail-com
_BUILD_POINT
v1.18.0-alpha.5.181-2e5d5ebf593c55
_RC_TAG
_RELEASE_TOOL_BRANCH
master
_RC
_RELEASE_TOOL_REPO
[:/]kubernetes/release
_OFFICIAL
_BUILD_AT_HEAD
_NOMOCK
_GIT_TAG
12345
_RELEASE_BRANCH
release-1.18
_KUBE_CROSS_VERSION
v1.13.6-1
_OFFICIAL_TAG
_BUILDVERSION
--buildversion=v1.18.0-alpha.5.181+2e5d5ebf593c55
_NOMOCK_TAG

/lgtm
/approve
/hold cancel
/priority important-soon

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [justaugustus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment