gh2gcs: when copying the package to cloud storage use the tag to set the path in the destination #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the path in the destination
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
area/release-eng
|
Perfect. Thanks @cpanato! |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, hasheddan, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
when copying a single tag to cloud storage it was not setting the package in the tag directory. with this fix it set the package in his own directory
Before:
command used:
gh2gcs --org kubernetes --repo kubernetes --bucket carlos-test-gcb --release-dir release --tags v1.18.0After the fix:
command used:
gh2gcs --org kubernetes --repo kubernetes --bucket carlos-test-gcb --release-dir release --tags v1.18.0with multiple tags:
command used:
gh2gcs --org kubernetes --repo kubernetes --bucket carlos-test-gcb --release-dir release --tags v1.18.0,v1.16.0,v1.19.0-rc.3Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
/assign @justaugustus