-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] gcb: Add hack to rewrite version markers #1640
Conversation
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus: Adding label: Reasons for blocking this PR:[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.] Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
GCB command invocation: $ time gcloud builds submit --no-source --project=kubernetes-release-test --config=gcb/fix/cloudbuild.yaml --substitutions=_TOOL_ORG=justaugustus,_TOOL_REPO=release,_TOOL_BRANCH=fix-marker
Created [https://cloudbuild.googleapis.com/v1/projects/kubernetes-release-test/builds/a1bac1b8-91a1-41ce-85d7-b46ee79f56c6].
Logs are available at [https://console.cloud.google.com/cloud-build/builds/a1bac1b8-91a1-41ce-85d7-b46ee79f56c6?project=648026197307]. Fix run is here: https://console.cloud.google.com/cloud-build/builds/a1bac1b8-91a1-41ce-85d7-b46ee79f56c6?project=kubernetes-release-test Log snips from GCB run (for those that don't have access): Writing v1.19.2 to fix_version.txt...
Updating stable to v1.19.2...
Copying file://fix_version.txt [Content-Type=text/plain]...
/ [0 files][ 0.0 B/ 8.0 B]
Operation completed over 1 objects/8.0 B.
Updating stable-1 to v1.19.2...
Copying file://fix_version.txt [Content-Type=text/plain]...
/ [0 files][ 0.0 B/ 8.0 B]
Operation completed over 1 objects/8.0 B.
Removing stable-1.20 marker...
Removing gs://kubernetes-release/release/stable-1.20.txt...
/ [1 objects]
Operation completed over 1 objects. Local check of version markers: $ for marker in stable stable-1 stable-1.20; do gsutil cat "gs://kubernetes-release/release/$marker.txt"; done
v1.19.2
v1.19.2
CommandException: No URLs matched: gs://kubernetes-release/release/stable-1.20.txt |
@kubernetes/release-engineering -- Does anyone want to take this and convert it into a |
@justaugustus I can take that :) |
Thanks Dan! |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Closing as this was just for an emergency fix. /close |
@justaugustus: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Reported in kubernetes/kubernetes#95536 / https://kubernetes.slack.com/archives/C2C40FMNF/p1602638351297900, our
stable
version markers are currently pointing to v1.20 pre-release versions, instead of v1.19.2.This is an emergency script (with many of the values hardcoded) to overwrite the production version markers.
Which issue(s) this PR fixes:
Special notes for your reviewer:
This is the hastily-written bash version of one of the potential "emergency commands" I was referencing in #1494.
I can take a crack at converting this to go when I have some time.
Does this PR introduce a user-facing change?