Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promobot: replace klog to use logrus #1800

Merged
merged 1 commit into from
Nov 28, 2020
Merged

promobot: replace klog to use logrus #1800

merged 1 commit into from
Nov 28, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 28, 2020

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

promobot: replace klog to use logrus to be compliance with all other pkg code we have in the repo

/assign @saschagrunert @hasheddan

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

promobot: replace klog to use logrus

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 28, 2020
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 28, 2020
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 28, 2020
hasheddan
hasheddan approved these changes Nov 28, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hasheddan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5cb960f into kubernetes:master Nov 28, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 28, 2020
@cpanato cpanato deleted the replace-log branch November 28, 2020 17:33
@cpanato cpanato mentioned this pull request Nov 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@saschagrunert saschagrunert

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cpanato @k8s-ci-robot @hasheddan @saschagrunert