Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go1.16] Build official images for go1.16.1 #1937

Merged
merged 5 commits into from
Mar 10, 2021

Conversation

justaugustus
Copy link
Member

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

(Part of #1936.)

ref: https://kubernetes.slack.com/archives/C2C40FMNF/p1615216589218000

  • kube-cross: Build v1.16.1-1 image
  • go-runner: Build v2.3.1-go1.16.1-buster.0 image
  • releng-ci: Build v0.5.0 image
  • vulndash: Build v0.4.3-6 image

/assign @hasheddan @saschagrunert @cpanato @puerco
cc: @kubernetes/release-engineering
/hold until after images are available on Wednesday, March 10

Which issue(s) this PR fixes:

Special notes for your reviewer:

vulndash is built for completeness, based on the current dependencies.yaml
definitions. The vulndash image will not be promoted.

Does this PR introduce a user-facing change?

- kube-cross: Build v1.16.1-1 image
- go-runner: Build v2.3.1-go1.16.1-buster.0 image
- releng-ci: Build v0.5.0 image
- vulndash: Build v0.4.3-6 image 

Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 9, 2021
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject labels Mar 9, 2021
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 9, 2021
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2021
@puerco
Copy link
Member

puerco commented Mar 9, 2021

/lgtm

1 similar comment
@ameukam
Copy link
Member

ameukam commented Mar 9, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

@justaugustus: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-release-image-kube-cross 0b400b9 link /test pull-release-image-kube-cross

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justaugustus justaugustus added this to the v1.21 milestone Mar 9, 2021
@justaugustus justaugustus added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Mar 9, 2021
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

the job for kube cross is building correctly the image, just not pushing due to some permissions I will followup with @spiffxp to get that fixed

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hasheddan, justaugustus, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,hasheddan,justaugustus,saschagrunert,xmudrii]
  • images/build/OWNERS [cpanato,hasheddan,justaugustus,saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member Author

Some, but not all of the manifests are available.
Will check back a little later.

@justaugustus
Copy link
Member Author

/hold cancel

$ crane manifest golang:1.16.1
2021/03/10 16:31:39 No matching credentials were found, falling back on anonymous
{"manifests":[{"digest":"sha256:593729df86eb9b82affa1d4489dee3c933f75e9aae12769bda95a97a9ad470d4","mediaType":"application\/vnd.docker.distribution.manifest.v2+json","platform":{"architecture":"amd64","os":"linux"},"size":1795},{"digest":"sha256:945b49609a74def30d655d54fa9a59e1c02cc8db75e5df94dac2fedb1b26f952","mediaType":"application\/vnd.docker.distribution.manifest.v2+json","platform":{"architecture":"arm","os":"linux","variant":"v5"},"size":1795},{"digest":"sha256:686e816bf0c3d51facb84c44bd66580e0df83e545f24e2f340dead1d96a05e93","mediaType":"application\/vnd.docker.distribution.manifest.v2+json","platform":{"architecture":"arm","os":"linux","variant":"v7"},"size":1795},{"digest":"sha256:d7f3985d077d55687af046ed9269bc97f2c69f780f2280b81d7f045cf06e58ed","mediaType":"application\/vnd.docker.distribution.manifest.v2+json","platform":{"architecture":"arm64","os":"linux","variant":"v8"},"size":1794},{"digest":"sha256:88a506c3c2dfbba94ad7c0488496d5802f4b5e46b05c03fcf43118046852f585","mediaType":"application\/vnd.docker.distribution.manifest.v2+json","platform":{"architecture":"386","os":"linux"},"size":1796},{"digest":"sha256:123692752cbe8c133a57dd54b6f515254afcf1fa11e574a363455f6fcfa5dc68","mediaType":"application\/vnd.docker.distribution.manifest.v2+json","platform":{"architecture":"mips64le","os":"linux"},"size":1795},{"digest":"sha256:99d7d379f0890cb6a8dcdd55df6aa11bac7d48d6c43ebc6f56954d46bde75d55","mediaType":"application\/vnd.docker.distribution.manifest.v2+json","platform":{"architecture":"ppc64le","os":"linux"},"size":1795},{"digest":"sha256:f6afacdc5aadd3a169f4199b8ab11b9286f3277de9e49c433ce1832ecfed7cde","mediaType":"application\/vnd.docker.distribution.manifest.v2+json","platform":{"architecture":"s390x","os":"linux"},"size":1795}],"mediaType":"application\/vnd.docker.distribution.manifest.list.v2+json","schemaVersion":2}

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8a0f6bd into kubernetes:master Mar 10, 2021
@spiffxp
Copy link
Member

spiffxp commented Mar 10, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants