Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go1.17] Default to go1.17 #2223

Merged
merged 6 commits into from
Aug 25, 2021
Merged

Conversation

justaugustus
Copy link
Member

What type of PR is this?

/kind cleanup feature
/area dependency

What this PR does / why we need it:

/hold for #2222

  • dependencies.yaml: Default to go1.17 for image builds
  • vulndash: Build v0.4.3-8 image
  • dependencies.yaml: Add entry for go.mod
  • packages/deb: Update module to go1.17
  • images/build/go-runner: Update module to go1.17
  • go.mod: Update module to go1.17

Which issue(s) this PR fixes:

Special notes for your reviewer:

I expect some failures here, either in image building or verify tests; just putting it up for early signal.

Does this PR introduce a user-facing change?

- [go1.17] Default to go1.17
  - dependencies.yaml: Default to go1.17 for image builds
  - vulndash: Build v0.4.3-8 image
  - dependencies.yaml: Add entry for go.mod
  - packages/deb: Update module to go1.17
  - images/build/go-runner: Update module to go1.17
  - go.mod: Update module to go1.17

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. needs-priority area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Aug 25, 2021
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 25, 2021
@justaugustus
Copy link
Member Author

justaugustus commented Aug 25, 2021

I expect the remaining tests to pass, but needs kubernetes/test-infra#23362 to fix this failure:

./hack/verify-go-mod.sh
go mod tidy: go.mod file indicates go 1.17, but maximum supported version is 1.16
make: *** [Makefile:52: verify-go-mod] Error 1 

EDIT: Confirmed that pull-release-verify is the only failing job now.

Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@cpanato
Copy link
Member

cpanato commented Aug 25, 2021

/test pull-release-verify

@justaugustus
Copy link
Member Author

/test pull-release-verify

@cpanato -- Needs kubernetes/test-infra#23362 to be approved first :)

@cpanato
Copy link
Member

cpanato commented Aug 25, 2021

/test pull-release-verify https://github.com/kubernetes/test-infra/pull/23362is merged :)

@justaugustus
Copy link
Member Author

/test pull-release-image-go-runner

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Stephen!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2021
@justaugustus
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit dd22359 into kubernetes:master Aug 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants