Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow fastforward to run non-interactive #2516

Merged
merged 1 commit into from
May 5, 2022
Merged

Allow fastforward to run non-interactive #2516

merged 1 commit into from
May 5, 2022

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented May 5, 2022 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

Recent runs of the fast-forward jobs are failing because we have no non-interactive flag for the GCB job run. We now fix that by making the question optional.

Example: https://storage.googleapis.com/kubernetes-jenkins/logs/ci-fast-forward/1522088732356775936/build-log.txt

Which issue(s) this PR fixes:

Refers to #2386

Special notes for your reviewer:

Gave it a test run in https://console.cloud.google.com/cloud-build/builds/c601bfb8-bf5e-4934-86f7-6f2165379823

Does this PR introduce a user-facing change?

Added `NonInteractive` flag to gcb options to allow asking no questions when running in nomock mode.

@saschagrunert
Allow fastforward to run non-interactive
d6d5b77 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels May 5, 2022
@ameukam
Copy link
Member

ameukam commented May 5, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6797628 into kubernetes:master May 5, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 5, 2022
@saschagrunert saschagrunert deleted the non-interactive-gcb branch May 5, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlydole onlydole Awaiting requested review from onlydole

@sethmccombs sethmccombs Awaiting requested review from sethmccombs

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saschagrunert @k8s-ci-robot @ameukam