Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert bumping kubernetes-cni to v1.2.0 and cri-tools to v1.26.0 #2875

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jan 25, 2023

What type of PR is this?

/kind regression

What this PR does / why we need it:

We bumped the minimum kubernetes-cni version to v1.2.0 in #2863, and cri-tools to v1.26.0 in #2821. However, this affects all kubelet and kubeadm packages, including v1.23.16, v1.24.10, v1.25.6, and v1.26.1.

This brings two major problems:

  • cri-tools v1.26.0 requires containerd 1.6, but many users are still using containerd 1.5, so they are now forced to upgrade
  • users are confused are cni-plugins v1.2.0 compatible with older minor releases
    • I'm also not sure that we properly or at all tested that

Therefore, we think it might be better to revert those bumps. This problem will be solved in the future with the KEP-1731 (kubernetes/enhancements#1731).

Which issue(s) this PR fixes:

Fixes #2866

Does this PR introduce a user-facing change?

Revert increasing the minimum kubernetes-cni and cri-tools versions

/assign @saschagrunert
cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jan 25, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 25, 2023
@xmudrii xmudrii added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 25, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 07f9170 into kubernetes:master Jan 25, 2023
@xmudrii xmudrii deleted the revert-bumps branch January 25, 2023 15:02
@dkoshkin
Copy link

Thank you for this fix! Are there plans to remove the kubernetes-cni v1.2.0 and cri-tools v1.26.0 packages from the repos?

Currently I still see it (atleast in the Deb repo) which means when kubeadm is installed it will bring these new versions with it, since they are the latest and there are not upper bounds.

@xmudrii
Copy link
Member Author

xmudrii commented Jan 25, 2023

We don't have such plans as of now and I'm also not sure if it is even technically feasible to remove packages. There are a few important notes regarding this PR:

  • This will be in effect starting with the February patch releases. We can't amend existing releases, so if this is an issue for you, we recommend staying on previous patch releases until February patch releases
  • We can't remove existing packages, but you will be able to manually bind to a lower version. For example, you will be able to do something like this: apt-get install kubeadm kubelet kubernetes-cni=1.1.1* cri-tools=1.25.0*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubeadm debian package v1.25.6 fails against v1alpha2 API CRI due to dependency on cri-tools >= 1.26.0
4 participants