Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-runner version in distroless-iptables. #2920

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

vinayakankugoyal
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

kubernetes is updating all go binaries to be built based on go lang versions 1.19.6 or 1.20.1.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Feb 17, 2023
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 17, 2023
@vinayakankugoyal
Copy link
Contributor Author

/assign @wespanther

@wespanther
Copy link
Contributor

Do we want to do debian-iptables as well while we're at it? It's in dependencies.yaml and images/build/debian-iptables/Makefile.

@wespanther
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2023
@vinayakankugoyal
Copy link
Contributor Author

/assign @cpanato

@wespanther
Copy link
Contributor

This distroless-iptables image takes a super long time to build (more than an hour from recent runs). I think it's because stage-binaries-from-package.sh installs the packages with apt serially, then has to create all the dirs and copy all the dependencies. Should be about half an hour left on the pull-release-image-distroless-iptable job.

@jrsapi jrsapi requested a review from puerco February 17, 2023 20:17
@cici37
Copy link
Contributor

cici37 commented Feb 17, 2023

/lgtm since #2909 completed
Will defer to @cpanato or @justaugustus for approval.

@cici37
Copy link
Contributor

cici37 commented Feb 17, 2023

I am proposing to have this updated together whenever there is a dependency update in #2909 (comment). Please let me know if there is any concern regarding with this proposal. Thank you

@jingyuanliang
Copy link
Contributor

We should do this earlier actually. We already missed (several?) Golang updates. I talked to @cpanato about this on Slack earlier.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, vinayakankugoyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit 79c2961 into kubernetes:master Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants