Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add osc to k8s-cloud-builder image #3084

Merged
merged 1 commit into from May 25, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented May 25, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds osc to k8s-cloud-builder image. osc is CLI for OpenBuildService (OBS) and we're going to use it for building and publishing packages. osc is available as a package in Debian repositories out of the box.

The list of packages that are added with the osc package:

The following additional packages will be installed:
  arch-test bash-completion cpio dbus debootstrap debugedit libapparmor1 libarchive-tools libarchive13
  libbytes-random-secure-perl libcrypt-random-seed-perl libcrypt-ssleay-perl libdbus-1-3 libdw1 liblua5.2-0
  libmath-random-isaac-perl libmath-random-isaac-xs-perl librpm9 librpmbuild9 librpmio9 librpmsign9 obs-build
  python3-cffi-backend python3-chardet python3-cryptography python3-jeepney python3-keyring python3-m2crypto
  python3-parameterized python3-pkg-resources python3-rpm python3-secretstorage python3-six python3-websocket rpm
  rpm-common rpm2cpio sudo wget xzdec
Suggested packages:
  libarchive1 default-dbus-session-bus | dbus-session-bus ubuntu-archive-keyring squid-deb-proxy-client rpm-i18n lrzip
  xfsprogs btrfs-progs python-cryptography-doc python3-cryptography-vectors gnome-keyring libkf5wallet-bin python3-dbus
  python3-keyrings.alt python-m2crypto-doc python3-setuptools python-secretstorage-doc alien elfutils rpmlint rpm2html
The following NEW packages will be installed:
  arch-test bash-completion cpio dbus debootstrap debugedit libapparmor1 libarchive-tools libarchive13
  libbytes-random-secure-perl libcrypt-random-seed-perl libcrypt-ssleay-perl libdbus-1-3 libdw1 liblua5.2-0
  libmath-random-isaac-perl libmath-random-isaac-xs-perl librpm9 librpmbuild9 librpmio9 librpmsign9 obs-build osc
  python3-cffi-backend python3-chardet python3-cryptography python3-jeepney python3-keyring python3-m2crypto
  python3-parameterized python3-pkg-resources python3-rpm python3-secretstorage python3-six python3-websocket rpm
  rpm-common rpm2cpio sudo wget xzdec
0 upgraded, 41 newly installed, 0 to remove and 16 not upgraded.

Special notes for your reviewer:

I have some concerns regarding the number of dependencies that are installed:

  • How much is that going to affect the image size?
  • How much is that going to affect the security of that image in term of number of vulnerabilities potentially affecting those packages now and in the future?

I decided to go with k8s-cloud-bulider because that's what we use in stage and release for krel. We'll extend stage and release steps with OBS workflow, so I wanted to keep the same image. Alternative is to create a new image or repurpose the kubepkg image, but I'm opening this PR to collect ideas and feedback.

Does this PR introduce a user-facing change?

Add `osc` (OpenBuildService CLI) to k8s-cloud-builder image

/assign @saschagrunert @cpanato @jeremyrickard
cc @kubernetes/release-engineering
/hold
for discussion

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels May 25, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels May 25, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 25, 2023
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking question: it is OK to install the latest available or should we pin to a specific version?

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member Author

xmudrii commented May 25, 2023

Non-blocking question: it is OK to install the latest available or should we pin to a specific version?

Latest is okay because we use managed OBS instance which is frequently updated. The commands that we use shouldn’t be changed frequently or at all.

@xmudrii
Copy link
Member Author

xmudrii commented May 25, 2023

Let’s iterate on this and we can always revert if needed
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit d27fc09 into kubernetes:master May 25, 2023
10 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 25, 2023
@xmudrii xmudrii deleted the osc-k8s-cloud-builder branch May 25, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants