Improvements and bug fixes for krel obs specs
#3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
sig/release
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
xmudrii
force-pushed
the
obs-specs-refactor-2
branch
from
3e35515
to
33309d3
Compare
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
xmudrii
force-pushed
the
obs-specs-refactor-2
branch
from
33309d3
to
f5b734e
Compare
saschagrunert
approved these changes
May 30, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-release-integration-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR is a minor refactor of
krel obs specscommand:krelpackagesimplinterface where neededThis refactor is supposed to make it easier to write tests for this package later.
Does this PR introduce a user-facing change?
/assign @saschagrunert @cpanato
cc @kubernetes/release-engineering