Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debian-base: switch to debian bookworm #3127

Merged
merged 1 commit into from Jul 4, 2023
Merged

debian-base: switch to debian bookworm #3127

merged 1 commit into from Jul 4, 2023

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Switching all images to debian 12 bookworm.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

/hold

For discussion about everything.

Does this PR introduce a user-facing change?

Using debian 12 (bookworm) for all images.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 21, 2023
@saschagrunert saschagrunert marked this pull request as ready for review June 21, 2023 12:42
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject labels Jun 21, 2023
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 21, 2023
@saschagrunert saschagrunert force-pushed the bookworm branch 2 times, most recently from ee3d455 to 7e4e3e8 Compare June 21, 2023 12:55
@saschagrunert saschagrunert mentioned this pull request Jun 21, 2023
Closed
44 tasks
@saschagrunert saschagrunert force-pushed the bookworm branch 2 times, most recently from 3c6c46a to 181ef64 Compare June 21, 2023 13:27
@saschagrunert saschagrunert changed the title WIP: Switch to debian bookworm WIP: debian-base, kube-cross, go-runner, ci, k8s-ci-builder: switch to debian bookworm Jun 21, 2023
@saschagrunert saschagrunert changed the title WIP: debian-base, kube-cross, go-runner, ci, k8s-ci-builder: switch to debian bookworm WIP: debian-base, kube-cross, ci, k8s-ci-builder: switch to debian bookworm Jun 21, 2023
@saschagrunert saschagrunert force-pushed the bookworm branch 2 times, most recently from 3c4323f to 4ca9531 Compare June 21, 2023 14:44
@saschagrunert saschagrunert changed the title WIP: debian-base, kube-cross, ci, k8s-ci-builder: switch to debian bookworm WIP: debian-base: switch to debian bookworm Jun 22, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 22, 2023
@saschagrunert saschagrunert changed the title WIP: debian-base: switch to debian bookworm debian-base: switch to debian bookworm Jun 22, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2023
@saschagrunert
Copy link
Member Author

Notification mail is out https://groups.google.com/g/kubernetes-sig-release/c/M-7rt-jvE-8/m/zK0lLxu6AgAJ

Setting lazy consens to July 1st before moving on with this topic.

cpanato
cpanato approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2023
@saschagrunert
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2023
@saschagrunert
debian-base: switch to bookworm
8227bf2 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 4, 2023 •
edited

@saschagrunert: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-release-image-debian-iptables 7e4e3e8 link true /test pull-release-image-debian-iptables
pull-release-image-setcap 7e4e3e8 link true /test pull-release-image-setcap
pull-release-image-releng-ci 4ca9531 link true /test pull-release-image-releng-ci

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

@kubernetes/release-managers PTAL

cpanato
cpanato approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b9077ce into kubernetes:master Jul 4, 2023
10 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 4, 2023
@saschagrunert saschagrunert deleted the bookworm branch July 4, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skitt skitt skitt left review comments

@jimangel jimangel jimangel left review comments

@cpanato cpanato cpanato approved these changes

@jrsapi jrsapi Awaiting requested review from jrsapi

@danwinship danwinship Awaiting requested review from danwinship

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@saschagrunert @k8s-ci-robot @skitt @cpanato @jimangel