Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rpmlint to releng-ci image #3167

Merged
merged 1 commit into from Jul 24, 2023
Merged

Add rpmlint to releng-ci image #3167

merged 1 commit into from Jul 24, 2023

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

We now feature the new tool in the CI image so that we can utilize it in the verify job.

Which issue(s) this PR fixes:

Part of #3166

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added `rpmlint` to releng-ci image `gcr.io/k8s-staging-releng/releng-ci:latest-go1.20-bookworm`.

@saschagrunert
Add rpmlint to releng-ci image
86b80ba 
We now feature the new tool in the CI image so that we can utilize it in
the verify job.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. needs-priority labels Jul 24, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 24, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2023
@saschagrunert
Copy link
Member Author

/test pull-release-test

xmudrii
xmudrii approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 28fee3f into kubernetes:master Jul 24, 2023
10 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 24, 2023
@saschagrunert saschagrunert deleted the rpmlint branch July 24, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@xmudrii xmudrii xmudrii approved these changes

@jrsapi jrsapi Awaiting requested review from jrsapi

@salaxander salaxander Awaiting requested review from salaxander

Assignees

@cpanato cpanato

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saschagrunert @k8s-ci-robot @cpanato @xmudrii