Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distroless-iptables: fix grep command #3237

Merged
merged 1 commit into from Aug 31, 2023

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Aug 31, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

The issue was that libaries from /usr/lib get symlinked from /lib, which is just a symlink to /usr/lib in debian 12. To avoid that, we now always refer to /usr/lib. To avoid wrong glibc versions we also have to use distroless/base-debian12.

Bumped the version of the image to v0.3.1.

Which issue(s) this PR fixes:

Refers to #3128

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Fixed `grep` usage in distroless-iptables, which is now on version v0.3.1.

The issue was that libaries from /usr/lib get symlinked from /lib, which
is just a symlink to /usr/lib in debian 12. To avoid that, we now always
refer to /usr/lib. To avoid wrong glibc versions we also have to use
distroless/base-debian12.

Bumped the version of the image to v0.3.1.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Aug 31, 2023
@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Aug 31, 2023
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 31, 2023
@saschagrunert saschagrunert mentioned this pull request Aug 31, 2023
44 tasks
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2023
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 958447d into kubernetes:master Aug 31, 2023
10 checks passed
saschagrunert added a commit to saschagrunert/kind that referenced this pull request Sep 5, 2023
Inherited from:

- kubernetes/release#3235
- kubernetes/release#3237

As well as bumping the haproxy version.

Tested via:

```
docker buildx build --platform=linux/amd64,linux/arm64  --progress=auto -t gcr.io/k8s-staging-kind/haproxy:v20230905-7dc7aad7 --pull --build-arg GO_VERSION=1.20.4  .
```

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert deleted the grep-fix branch September 5, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants