Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version discovery for cri-tools and kubernetes-cni packages #3629

Merged
merged 2 commits into from
Jun 1, 2024

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented May 31, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add version discovery to the krel obs specs command for cri-tools and kubernetes-cni packages. If the version is not provided, the latest version will be fetched from GitHub and used to create the package sources and specs. Prior to this change, if the version wasn't provided, the command would fail. This change is making it easier to implement tests.

Which issue(s) this PR fixes:

Required for #3589

Special notes for your reviewer:

This PR requires kubernetes-sigs/release-utils#104. I bumped the dependency to the latest revision, but we might want to do a new release-utils release as well.

Does this PR introduce a user-facing change?

Add version discovery to the `krel obs specs` command for `cri-tools` and `kubernetes-cni` packages

/assign @cpanato @saschagrunert @puerco
cc @kubernetes/release-engineering

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 31, 2024
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 31, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels May 31, 2024
@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label May 31, 2024
@k8s-ci-robot k8s-ci-robot requested a review from jrsapi May 31, 2024 17:48
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 31, 2024
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member

cpanato commented Jun 1, 2024

/skip

@cpanato
Copy link
Member

cpanato commented Jun 1, 2024

/override "Dependency Review / dependency-review (pull_request)"

@k8s-ci-robot
Copy link
Contributor

@cpanato: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Dependency Review / dependency-review (pull_request)

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • pull-release-integration-test
  • pull-release-test
  • pull-release-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Dependency Review / dependency-review (pull_request)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cpanato
Copy link
Member

cpanato commented Jun 1, 2024

/override "dependency-review"

@k8s-ci-robot
Copy link
Contributor

@cpanato: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • dependency-review

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • pull-release-integration-test
  • pull-release-test
  • pull-release-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "dependency-review"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cpanato cpanato merged commit fafcc8c into kubernetes:master Jun 1, 2024
9 of 11 checks passed
@xmudrii xmudrii deleted the version-discovery branch June 1, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants