-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sig labels to markdown #3684
Add sig labels to markdown #3684
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit. @npolshakova thank you for approaching a fix! Can you verify if that works for you?
Co-authored-by: Sascha Grunert <sgrunert@redhat.com>
Yep, the unit test confirmed it but I also re-ran krel to sanity check the sig labels are now being added and none of the sig labels are removed: https://github.com/kubernetes/sig-release/pull/2570/files#r1683006327 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: npolshakova, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Slack discussion: https://kubernetes.slack.com/archives/CN1KH4K9A/p1721224163843589
Which issue(s) this PR fixes:
When the map file text is replaced, the resulting markdown does not include the SIG labels. See an example of this where the old release notes have the sig labels removed.
You can reproduce this by running with the latest krel:
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?