Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kind, sig labels auto-copy to PRs #33

Closed
jberkus opened this issue Nov 17, 2017 · 3 comments
Closed

Make kind, sig labels auto-copy to PRs #33

jberkus opened this issue Nov 17, 2017 · 3 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@jberkus
Copy link
Contributor

jberkus commented Nov 17, 2017

Due to the changes from PR milestone automation (#26), we now have a hard requirement that kind, sig and priority labels need to be populated for PRs. I propose that we add to our automation to make that easy, specifically:

If a PR is linked to an issue, and the PR has no kind, sig, or priority labels, the kind, sig and priority labels from the linked issue should be copied to the PR automatically.

Obstacle: Github's notion of a PR being linked to an issue is rather loose; basically, if the PR is mentioned at all in the issue. This could lead to PRs being tagged that are only mentioned tangentally. Is there a useful way around this?

@enisoc
Copy link
Member

enisoc commented Nov 17, 2017

I'd be in favor of an explicit command to set the associated issue, like:

/issue #33

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 15, 2018
@jberkus
Copy link
Contributor Author

jberkus commented Feb 15, 2018

Closing this because I don't see any reasonable way to accomplish it, unless the SIGs adopt some kind of tagging format.

@jberkus jberkus closed this as completed Feb 15, 2018
@justaugustus justaugustus added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

5 participants