Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to relevant docs in Release Notes #667

Closed
jeefy opened this issue Jun 14, 2019 · 8 comments
Closed

Add links to relevant docs in Release Notes #667

jeefy opened this issue Jun 14, 2019 · 8 comments
Assignees
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@jeefy
Copy link
Member

jeefy commented Jun 14, 2019

Per https://kubernetes.slack.com/archives/C2C40FMNF/p1560536323319700

It'd be awesome if, in the release notes, we link to new and/or relevant documentation on the K8s website. I think this is entirely reasonable and something that should be looked into in the next release or so.

With the website it would be relatively easy and painless to add a new (optional) field in the JSON. That way it could be captured by either a field in the PR template OR a separate PR to update the JSON with the doc(s) link.

@jeefy
Copy link
Member Author

jeefy commented Jun 14, 2019

/kind feature
/area release-eng
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/release-eng Issues or PRs related to the Release Engineering subproject priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jun 14, 2019
@jeefy
Copy link
Member Author

jeefy commented Jun 14, 2019

/assign @saschagrunert @jeefy

@saschagrunert
Copy link
Member

How about adding an additional section to the PR template, which could be parsed by the release-notes tool afterwards:

\   ```documentation
\    - Link
\    - Link
\    - Link
\   ```

@pswica
Copy link

pswica commented Jun 19, 2019

@saschagrunert
I think it's a great idea.

I think we would need to parse the links to make sure that they are on the Kubernetes website. Other things to keep in mind are links changing on the website overtime. A final thing thing to address would be irrelevant links. What if people added a link to the main kubernetes website for their PR. Would that really be relevant if it appeared dispersed over 20 PRs or so?

@saschagrunert
Copy link
Member

What if people added a link to the main kubernetes website for their PR. Would that really be relevant if it appeared dispersed over 20 PRs or so?

Yeah I guess we have to review the PRs with keeping in mind that the documentation links will appear in the release-notes and need to add valuable benefits to the users. Nevertheless we can parse all URLs and classify them by the location. So we would be able to separate KEP links or filter only for KEPs inside the website.

@saschagrunert
Copy link
Member

@jeefy do we want to close this or is there anything else which needs to be done? :)

@jeefy
Copy link
Member Author

jeefy commented Jul 29, 2019

🌮

/close

@k8s-ci-robot
Copy link
Contributor

@jeefy: Closing this issue.

In response to this:

🌮

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus justaugustus added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

5 participants