Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update base image exceptions list #1084

Merged
merged 4 commits into from
May 14, 2020
Merged

Update base image exceptions list #1084

merged 4 commits into from
May 14, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented May 9, 2020 •
edited
Loading

What type of PR is this:

/kind cleanup documentation

What this PR does / why we need it:

  • Fixup table formatting for exceptions list
  • Split exceptions into release and non-release images
  • Update exception images and assumed OWNERS
  • Update exceptions for release images

ref: kubernetes/kubernetes#70249, kubernetes/kubernetes#90698, kubernetes/kubernetes#90804, kubernetes/kubernetes#90674

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 9, 2020
@justaugustus
base-images: Fixup table formatting for exceptions list
71a25cf 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
base-images: Split exceptions into release and non-release images
e3f52f5 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
base-images: Update exception images and assumed OWNERS
6f61cfd 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus justaugustus changed the title [WIP] Update base image exceptions list Update base image exceptions list May 10, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2020
@justaugustus
Copy link
Member Author

/assign @tpepper @dims
/area dependency security
cc: @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label May 10, 2020
@k8s-ci-robot
Copy link
Contributor

@justaugustus: The label(s) area/security cannot be applied, because the repository doesn't have them

In response to this:

/assign @tpepper @dims
/area dependency security
cc: @kubernetes/release-engineering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member Author

/kind cleanup documentation
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels May 10, 2020
dims
dims reviewed May 10, 2020
View reviewed changes
release-engineering/baseimage-exception-list.md Outdated
| Image Name | Reasons for exception |
|---|---|
| [debian-iptables] | Needed to supported images that require `iptables` |
| [kube-controller-manager][core-images] | `klog` 2000 node scalability regressions, [Flexvolume master driver is blocking controller-manager from moving to distroless](https://github.com/kubernetes/kubernetes/issues/78737) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the "klog" 2000 node scalability regressions, , no longer applicable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dims -- Fixed!

@justaugustus
base-images: Update exceptions for release images
cd81fc6 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@dims
Copy link
Member

dims commented May 11, 2020

/assign @tallclair

@tpepper
Copy link
Member

tpepper commented May 12, 2020

lgtm but will leave for the other Tim @tallclair

@tallclair
Copy link
Member

/lgtm

thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2b93378 into kubernetes:master May 14, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 14, 2020
@kikisdeliveryservice kikisdeliveryservice mentioned this pull request Oct 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@sumitranr sumitranr Awaiting requested review from sumitranr

Assignees

@dims dims

@tpepper tpepper

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@justaugustus @k8s-ci-robot @dims @tpepper @tallclair