Update the branch manager role handbook with additional details #1277
Conversation
k8s-ci-robot
added
kind/documentation
k8s-ci-robot
added
area/release-eng
| ```shell | ||
| go get sigs.k8s.io/k8s-container-image-promoter/cmd/cip-mm@master | ||
| ``` |
There was a problem hiding this comment.
I'm not sure is it fully-correct, but I've tested this command locally and it worked.
There was a problem hiding this comment.
I believe you will still need to go install (https://github.com/kubernetes/sig-release/blob/master/release-engineering/role-handbooks/release-image-promotion.md)
There was a problem hiding this comment.
Be aware that we're on our way to remove the dependency by using the image promoter as a library.
There was a problem hiding this comment.
I believe you will still need to go install (https://github.com/kubernetes/sig-release/blob/master/release-engineering/role-handbooks/release-image-promotion.md)
I'll link to this document for instructions on how to install it.
Be aware that we're on our way to remove the dependency by using the image promoter as a library.
@saschagrunert Should I add a note for that or just drop cip-mm as a requirement?
There was a problem hiding this comment.
I think you an leave it for now and add a HTML comment TODO that we have to remove it once the efforts in k/release got merged.
There was a problem hiding this comment.
@saschagrunert I've added a TODO.
|
/hold since this is still under review and Marko has superpowers in the repo now |
k8s-ci-robot
added
the
do-not-merge/hold
| ```shell | ||
| go get sigs.k8s.io/k8s-container-image-promoter/cmd/cip-mm@master | ||
| ``` |
There was a problem hiding this comment.
Be aware that we're on our way to remove the dependency by using the image promoter as a library.
|
@saschagrunert @hasheddan @cpanato I've fixed some of the comments, PTAL is it okay now. |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, justaugustus, saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this:
/kind documentation
/kind cleanup
What this PR does / why we need it:
This PR updates the Branch Manager role handbook with more up-to-date details about setting up the environment and cutting releases.
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
None.
/assign @saschagrunert @justaugustus @cpanato