Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IPVS topics in release notes draft #194

Closed
wants to merge 1 commit into from

Conversation

Lion-Wei
Copy link

No description provided.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 20, 2018
@Lion-Wei
Copy link
Author

@m1093782566 @calebamiles PTAL, thanks.

@jhorwit2
Copy link

@Lion-Wei should we also call out the known issue with graceful termination here? kubernetes/kubernetes#57841

@calebamiles
Copy link
Contributor

/approve
/lgtm
/hold

@Lion-Wei please resolve the comment from @jhorwit2 and remove the hold. Thanks!

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: calebamiles, Lion-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2018
@Lion-Wei
Copy link
Author

@calebamiles Thanks.
@jhorwit2 , Thanks for reminding. We do have this issue in discuss, but I'm not sure is this necessary to call out a known issue.
@m1093782566 , what do you think?

@m1093782566
Copy link

what about creating an action-required item?

@Lion-Wei
Copy link
Author

I think known issue is fine.
@calebamiles , Should I add known issue to release_notes_draft.md or other document? Cause I didn't found any known issue related item in release_notes_draft.md.
Thanks.

@Lion-Wei
Copy link
Author

I think the known issue description should be like:

Known Issue

IPVS based kube-proxy doesn't support graceful close connections for terminating pod. This issue will be fixed in a future release.
For more information, see https://github.com/kubernetes/kubernetes/issues/57841.

WHat do you think? @jhorwit2

@nickchase
Copy link
Contributor

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants