Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] makefile wrapping concept #621

Closed
wants to merge 2 commits into from

Conversation

tpepper
Copy link
Member

@tpepper tpepper commented May 9, 2019

The commit looks fugly, but basically is adding a third column to the table introduced in #620

For a concrete discussion on tools improvement, I want to show what I'm imagining it might look like to establish a wrapping of the detailed commands which do build and publish.

My goal is to allow parallel back end implementations and proof-of-concept comparisons. If the top level flow is abstracted and callable by automation, without those tools getting coupled to the internal implementation, we are in a more flexible and testable place and enable more to be done through automation.

Tim Pepper added 2 commits May 9, 2019 10:15
The order of operations in the release workflow is a mix of complicated,
error-prone command invocations, and manual synchronization check
points.  A summary of these is needed to make the required actions more
clear.

Also adds a table of contents as intradoc links makes eaiser navigating to the
appropriate info a different points in a process that spans days or even
weeks.

Signed-off-by: Tim Pepper <tpepper@vmware.com>
For a concrete discussion on tools improvement, I want to show what
I'm imagining it might look like to establish a wrapping of the
detailed commands which do build and publish.

My goal is to allow parallel back end implementations and
proof-of-concept comparisons.  If the top level flow is abstracted
and callable by automation, without those tools getting coupled to
the internal implementation, we are in a more flexible and testable
place and enable more to be done through automation.
@tpepper tpepper added the area/release-eng Issues or PRs related to the Release Engineering subproject label May 9, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 9, 2019
@tpepper
Copy link
Member Author

tpepper commented May 9, 2019

/hold

here for discussion

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/release-team Issues or PRs related to the release-team subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 9, 2019
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer May 9, 2019 17:29
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tpepper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2019
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2019
@k8s-ci-robot
Copy link
Contributor

@tpepper: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus justaugustus added this to In progress in Release Team Jun 6, 2019
@justaugustus
Copy link
Member

/milestone v1.16
/priority important-longterm
/kind documentation feature

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jul 30, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 30, 2019
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 30, 2019
@justaugustus
Copy link
Member

/close
to revisit in handbook rewrites

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Closed this PR.

In response to this:

/close
to revisit in handbook rewrites

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Release Team automation moved this from In progress to Done (1.16) Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants