Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE Feed: Include a timestamp field for each CVE indicating when it was last updated #63

Closed
Tracked by #1
Dentrax opened this issue Sep 16, 2022 · 13 comments
Closed
Tracked by #1
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/security Categorizes an issue or PR as relevant to SIG Security. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@Dentrax
Copy link

Dentrax commented Sep 16, 2022

This is a Feature Request

-

What would you like to be added

https://kubernetes.io/docs/reference/issues-security/official-cve-feed/index.json

  • Add lastUpdateTime timestamp field in the root.
  • Add timestamp field to CVE entry

Why is this needed

In the current response, there is no lastUpdateTime field. So it's challenging to distinguish when the CVE Feed is actually updated or it's already up-to-date.

I think timestamp field is also necessary to indicate when the CVE is added to the feed. There could be a time-window between CVE discover time versus CVE added to feed time.

Alternative Solution:

Use RSS 2.0 standard instead for better scaling for further requirement needs.

Comments
-

cc @developer-guy

@Dentrax Dentrax added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 16, 2022
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 16, 2022
@k8s-ci-robot
Copy link
Contributor

@Dentrax: This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sftim
Copy link
Contributor

sftim commented Sep 16, 2022

/sig security

@k8s-ci-robot k8s-ci-robot added the sig/security Categorizes an issue or PR as relevant to SIG Security. label Sep 16, 2022
@sftim
Copy link
Contributor

sftim commented Sep 16, 2022

The timestamp could be the date time of issue creation (GitHub issues are the source of truth). lastUpdateTime sounds more tricky to implement, but would be possible I think.

@sftim
Copy link
Contributor

sftim commented Sep 16, 2022

timestamp could come from created_at in the GitHub Issues API
for lastUpdateTime, I'd take the maximum of updated_at from the GitHub Issues API, and the last update date for the JSON feed page. That way, if we change the feed rendering in the website, we can bump the last update date appropriately.

@Dentrax
Copy link
Author

Dentrax commented Sep 16, 2022

I can submit a PR for this if does it make sense overall. Where can I find the cve-feed-api source code? Any actions required in frontend? (i.e., adding new column for timestamp)

@sftim
Copy link
Contributor

sftim commented Sep 16, 2022

https://www.k8s.dev/blog/2022/09/12/k8s-cve-feed-alpha/ outlines the implementation @Dentrax

Given that this is relevant to #1, I will transfer this issue to that other repo:
/transfer sig-security

@k8s-ci-robot k8s-ci-robot transferred this issue from kubernetes/website Sep 16, 2022
@sftim
Copy link
Contributor

sftim commented Sep 16, 2022

Once the upstream feed has this data, we may also want changes to k/website to make that last updated information available.

For example, we could calculate an overall last-updated for the whole feed, and put that onto https://kubernetes.io/docs/reference/issues-security/official-cve-feed/ as text.

@PushkarJ
Copy link
Member

/retitle CVE Feed: Include a timestamp field for each CVE indicating when it was last updated

(Dividing the scope between this issue and #73 and #72)

@k8s-ci-robot k8s-ci-robot changed the title CVE Feed: Consider to include a timestamp field to indicate when a CVE is added to feed CVE Feed: Include a timestamp field for each CVE indicating when it was last updated Nov 22, 2022
@mtardy
Copy link
Member

mtardy commented Dec 20, 2022

This would be trivial to implement after this one is merged #75.
I could do it quickly!
/assign

@mtardy
Copy link
Member

mtardy commented Dec 20, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Dec 20, 2022
@mtardy
Copy link
Member

mtardy commented Dec 20, 2022

I just added a commit to fix this in #75 (comment).

@PushkarJ
Copy link
Member

Fixed by #76 via date_published field. Feel free to re-open if you think this needs more work to be resolved.

/close

@k8s-ci-robot
Copy link
Contributor

@PushkarJ: Closing this issue.

In response to this:

Fixed by #76 via date_published field. Feel free to re-open if you think this needs more work to be resolved.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PushkarJ PushkarJ moved this from To do to Ready for Co-Chair Review in sig-security-tracker Jun 7, 2023
@PushkarJ PushkarJ moved this from Ready for Co-Chair Review to Done in sig-security-tracker Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/security Categorizes an issue or PR as relevant to SIG Security. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Development

No branches or pull requests

5 participants