Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump prow from v20181129-31c544b to v20181203-6a1345b #10298

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Bump prow from v20181129-31c544b to v20181203-6a1345b #10298

merged 1 commit into from
Dec 3, 2018

Conversation

k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Nov 30, 2018 •
edited
Loading

Included changes: 31c544b...6a1345b

@k8s-ci-robot
Copy link
Contributor Author

Welcome @k8s-ci-robot! It looks like this is your first PR to kubernetes/test-infra 🎉🎉

@k8s-ci-robot
Copy link
Contributor Author

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 30, 2018
@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow area/prow/bump Updates to the k8s prow cluster labels Nov 30, 2018
@fejta
Copy link
Contributor

fejta commented Nov 30, 2018

woo!

@ixdy
Copy link
Member

ixdy commented Nov 30, 2018

@k8s-ci-robot, can you please sign the CLA? thanks!

@stevekuznetsov
Copy link
Contributor

Welcome @k8s-ci-robot! It looks like this is your first PR to kubernetes/test-infra 🎉🎉

Oh, @k8s-ci-robot you think commits are your ally. But you merely adopted the commits; @k8s-ci-robot was born in them, molded by them.

$ git log --merges --format=%ae | sort | uniq -c | sort -rh | head -n 1
   3951 k8s-ci-robot@users.noreply.github.com

@krzyzacy
Copy link
Member

/woof

@k8s-ci-robot
Copy link
Contributor Author

@krzyzacy: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikopen
Copy link
Contributor

nikopen commented Nov 30, 2018

/meow

@k8s-ci-robot
Copy link
Contributor Author

@nikopen: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor Author

If I were @krzyzacy this is about the time I'd mistakenly start LGTMing random PRs from the wrong account

@fejta
Copy link
Contributor

fejta commented Nov 30, 2018

woops

@krzyzacy
Copy link
Member

/joke
naughty!

@k8s-ci-robot
Copy link
Contributor Author

@krzyzacy: Some people say that comedians who tell one too many light bulb jokes soon burn out, but they don't know watt they are talking about. They're not that bright.

In response to this:

/joke
naughty!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krzyzacy
Copy link
Member

also, s/mistakenly/intentionally

@k8s-ci-robot
Copy link
Contributor Author

yes @stevekuznetsov I have free will to sign the CLA

@k8s-ci-robot
Copy link
Contributor Author

hello world?

@krzyzacy
Copy link
Member

krzyzacy commented Dec 1, 2018

@k8s-ci-robot test this

@k8s-ci-robot k8s-ci-robot changed the title Bump prow from v20181129-31c544b to v20181130-d7867ec Bump prow from v20181129-31c544b to v20181201-902567d Dec 1, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 1, 2018
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 1, 2018
@k8s-ci-robot
Copy link
Contributor Author

Finally @k8s-ci-robot, you're a tough bot to please

@fejta
Copy link
Contributor

fejta commented Dec 1, 2018

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2018
@fejta
Copy link
Contributor

fejta commented Dec 1, 2018

I'll rerun this job after #10299 merges to remove the other commits.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 2, 2018
@k8s-ci-robot k8s-ci-robot changed the title Bump prow from v20181129-31c544b to v20181201-902567d Bump prow from v20181129-31c544b to v20181201-6af1000 Dec 2, 2018
@k8s-ci-robot k8s-ci-robot changed the title Bump prow from v20181129-31c544b to v20181201-6af1000 Bump prow from v20181129-31c544b to v20181203-6a1345b Dec 3, 2018
@fejta
Copy link
Contributor

fejta commented Dec 3, 2018

/hold cancel

Ben can we merge this one? @BenTheElder

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2018
@BenTheElder
Copy link
Member

/hold cancel

BenTheElder
BenTheElder approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/shipit
welcome robot overlords! 🤖

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2018
@k8s-ci-robot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: f2778aa18a408644514eddd9b8e4f8a0527408e9

@k8s-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, k8s-ci-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2018
@fejta
Copy link
Contributor

fejta commented Dec 3, 2018

merge merge merge!

@k8s-ci-robot k8s-ci-robot merged commit 3434daf into kubernetes:master Dec 3, 2018
@k8s-ci-robot
Copy link
Contributor Author

@k8s-ci-robot: Updated the config configmap using the following files:

  • key config.yaml using file prow/config.yaml

In response to this:

Included changes: 31c544b...6a1345b

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@cjwagner cjwagner Awaiting requested review from cjwagner

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/prow/bump Updates to the k8s prow cluster area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@k8s-ci-robot @fejta @ixdy @stevekuznetsov @krzyzacy @nikopen @BenTheElder