Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding/json expects omitempty, not omit_empty #10367

Merged
merged 1 commit into from
Dec 6, 2018
Merged

encoding/json expects omitempty, not omit_empty #10367

merged 1 commit into from
Dec 6, 2018

Conversation

Katharine
Copy link
Member

This is causing gubernator to crash when viewing builds where this field is empty, and is also not what was intended.

I'm disappointed some sort of linter/checker/something didn't notice this.

/cc @krzyzacy @cjwagner @stevekuznetsov

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow area/prow/pod-utilities Issues or PRs related to prow's pod-utilities component area/prow/sidecar Issues or PRs related to prow's sidecar component labels Dec 6, 2018
@Katharine Katharine mentioned this pull request Dec 6, 2018
Merged
@stevekuznetsov
Copy link
Contributor

#6092

@stevekuznetsov
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2018
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 70b035cf86c8e4bb527afe71e8344e8b6831055a

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Katharine, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit aa9221d into kubernetes:master Dec 6, 2018
@krzyzacy
Copy link
Member

krzyzacy commented Dec 6, 2018

😢 I'll add a unit test here, was thinking of how to mock out the gcs upload call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjwagner cjwagner Awaiting requested review from cjwagner

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/pod-utilities Issues or PRs related to prow's pod-utilities component area/prow/sidecar Issues or PRs related to prow's sidecar component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Katharine @stevekuznetsov @k8s-ci-robot @krzyzacy