Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sig-storage testgrid #10696

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Update sig-storage testgrid #10696

merged 1 commit into from
Jan 17, 2019

Conversation

cofyc
Copy link
Member

@cofyc cofyc commented Jan 10, 2019

  • rename current sig-storage dashboard to sig-storage-kubernetes
  • add new sig-storage dashboard group

xref: #10630 (comment)

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 10, 2019
@cofyc
Copy link
Member Author

cofyc commented Jan 10, 2019

/assign @michelle192837 @msau42

@cofyc cofyc mentioned this pull request Jan 10, 2019
Merged
@michelle192837
Copy link
Contributor

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 10, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ffb52f398dbce4962a156531086cf2b0ff9bfbb1

@msau42
Copy link
Member

msau42 commented Jan 10, 2019

/lgtm

@msau42
Copy link
Member

msau42 commented Jan 11, 2019

@michelle192837 is there anything else waiting on the hold?

@msau42 msau42 mentioned this pull request Jan 11, 2019
Merged
@cofyc
Copy link
Member Author

cofyc commented Jan 17, 2019

@michelle192837 hi, could you approve too?

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2019
BenTheElder
BenTheElder approved these changes Jan 17, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold cancel

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cofyc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit b85f312 into kubernetes:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@michelle192837 michelle192837 Awaiting requested review from michelle192837

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@michelle192837 michelle192837

@BenTheElder BenTheElder

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cofyc @michelle192837 @k8s-ci-robot @msau42 @BenTheElder