Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some area/foo labels for subprojects #10758

Merged
merged 2 commits into from Jan 15, 2019
Merged

Add some area/foo labels for subprojects #10758

merged 2 commits into from Jan 15, 2019

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jan 14, 2019

/sig contributor-experience
for devstats
/sig release
for release-team and hyperkube

@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/label_sync Issues or PRs related to code in /label_sync area/prow Issues or PRs related to prow area/prow/deck Issues or PRs related to prow's deck component sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 14, 2019
@spiffxp
Copy link
Member Author

spiffxp commented Jan 14, 2019

I noticed devstats was missing when I opened kubernetes/community#3094

@spiffxp
Copy link
Member Author

spiffxp commented Jan 15, 2019

/hold
for comment

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2019
justaugustus
justaugustus suggested changes Jan 15, 2019
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @spiffxp, that I'd like the area/release-team label to k/community as well.
There are still a few things that would be RT-related.

@spiffxp spiffxp force-pushed the add-some-subproject-area-labels branch from 4f31544 to 01680fc Compare January 15, 2019 01:13
@justaugustus
Copy link
Member

For SIG Release:
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4ece8288f93421bb65ef7a6faf015ae6da4c234a

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, justaugustus, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member Author

spiffxp commented Jan 15, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4293f77 into kubernetes:master Jan 15, 2019
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the label-config configmap using the following files:

  • key labels.yaml using file label_sync/labels.yaml

In response to this:

/sig contributor-experience
for devstats
/sig release
for release-team and hyperkube

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the add-some-subproject-area-labels branch January 15, 2019 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus requested changes

@cblecker cblecker cblecker approved these changes

@fejta fejta Awaiting requested review from fejta

@Katharine Katharine Awaiting requested review from Katharine

Assignees

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/label_sync Issues or PRs related to code in /label_sync area/prow/deck Issues or PRs related to prow's deck component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spiffxp @justaugustus @k8s-ci-robot @cblecker