Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kubernetes repo for NPD node e2e tests #11793

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Add kubernetes repo for NPD node e2e tests #11793

merged 1 commit into from
Mar 15, 2019

Conversation

wangzhen127
Copy link
Member

Running node e2e tests need access to kubernetes code instead of release binary. This PR adds the extra kubernetes repo for NPD node e2e jobs.

Part of kubernetes/node-problem-detector#236.

@wangzhen127
Copy link
Member Author

/assign @krzyzacy

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 14, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2019
wangzhen127
wangzhen127 commented Mar 14, 2019
View reviewed changes
config/jobs/kubernetes/node-problem-detector/node-problem-detector-ci.yaml
@@ -56,6 +56,10 @@ periodics:
repo: node-problem-detector
base_ref: master
path_alias: k8s.io/node-problem-detector
- org: kubernetes
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krzyzacy, for the extra_refs, the default path is in the first repository, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2019
krzyzacy
krzyzacy approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@krzyzacy krzyzacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

(see if it works...)

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3765d4c5a9de054e08730eb56eb7b5770e5fb676

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit aaeae12 into kubernetes:master Mar 15, 2019
@k8s-ci-robot
Copy link
Contributor

@wangzhen127: Updated the job-config configmap in namespace default using the following files:

  • key node-problem-detector-ci.yaml using file config/jobs/kubernetes/node-problem-detector/node-problem-detector-ci.yaml
  • key node-problem-detector-presubmits.yaml using file config/jobs/kubernetes/node-problem-detector/node-problem-detector-presubmits.yaml

In response to this:

Running node e2e tests need access to kubernetes code instead of release binary. This PR adds the extra kubernetes repo for NPD node e2e jobs.

Part of kubernetes/node-problem-detector#236.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wangzhen127 wangzhen127 deleted the npd-node branch March 15, 2019 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzacy krzyzacy krzyzacy approved these changes

@andyxning andyxning Awaiting requested review from andyxning

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@krzyzacy krzyzacy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wangzhen127 @k8s-ci-robot @krzyzacy