enhance(jobs): adds jobs for azurefile csi driver #12386
Conversation
|
Welcome @ashishranjan738! |
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @ashishranjan738. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
Signed-off-by: Ashish Ranjan <ashishranjan738@gmail.com> This commit adds jobs for azurefile-csi-driver. These jobs will be testing the azurefile csi driver's PR against unit,sanity,integration and e2e tests.
ashishranjan738
force-pushed
the
azurefile
branch
from
0a4ab45
to
b25adc3
Compare
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
| - runner.sh | ||
| args: | ||
| - make | ||
| - test-e2e |
There was a problem hiding this comment.
@andyzhangx Do we need to configure Azure accounts for e2e tests?
There was a problem hiding this comment.
I think yes
There was a problem hiding this comment.
Will this https://github.com/kubernetes-sigs/azurefile-csi-driver/blob/master/hack/run-e2e-test.sh be the right place for doing that ?
There was a problem hiding this comment.
pls use this config for reference: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-azure/sig-azure-config.yaml
Hi @ritazh, do you know about how to enable this azure e2e test on csi driver? The above config runs conformance test, while for csi driver, it should run PV related test.
There was a problem hiding this comment.
@andyzhangx Let's test the configure on our own prow first. Could you add me to the csi repo admins? I need to update hooks for setup the prow job
There was a problem hiding this comment.
@andyzhangx To run conformance test against a cluster with the azurefile csi driver, I would first create a cluster with your csi driver installed, then run conformance test against it.
Take a look at this job: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/cloud-provider-azure/cloud-provider-azure-config.yaml#L274-L325 It is running conformance test against a cluster that was created with aks-engine using a template that has customCcmImage configured https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/cloud-provider-azure/cloud-provider-azure-config.yaml#L315 Although I'm not sure if the azurefile csi driver has been added to aks-engine yet.
k8s-ci-robot
added
the
do-not-merge/hold
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
lifecycle/rotten
|
@andyzhangx are you still working on this? |
no bandwith now.. |
|
Do you guys need help with this? |
It would be great if someone could help to enable this, thanks @ritazh |
|
cc @chewong |
|
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
|
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen |
|
@andyzhangx: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ashishranjan738 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ashishranjan738: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close |
|
@chewong: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Ashish Ranjan ashishranjan738@gmail.com
This commit adds jobs for azurefile-csi-driver. These jobs will be testing the azurefile csi driver's PR against unit,sanity,integration and e2e tests.