Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use prow for client-go/unofficial-docs #12870

Merged

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Jun 4, 2019

Ref: #12863

The repo does not belong to the Kubernetes project and is inactive.

I'll also remove the webhook.

cc @sttts @munnerz @lilic
/assign @cblecker @spiffxp

The repo does not belong to Kubernetes and is inactive.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 4, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/prow Issues or PRs related to prow sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 4, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3e29d2093ab6fd2cc73245546504b2b674a13aa1

Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@k8s-ci-robot
Copy link
Contributor

@lilic: changing LGTM is restricted to assignees, and only kubernetes/test-infra repo collaborators may be assigned issues.

In response to this:

Makes sense 👍

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker
Copy link
Member

cblecker commented Jun 4, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, LiliC, matthyx, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4d6fd59 into kubernetes:master Jun 4, 2019
@k8s-ci-robot
Copy link
Contributor

@nikhita: Updated the following 2 configmaps:

  • config configmap in namespace default using the following files:
    • key config.yaml using file prow/config.yaml
  • plugins configmap in namespace default using the following files:
    • key plugins.yaml using file prow/plugins.yaml

In response to this:

Ref: #12863

The repo does not belong to the Kubernetes project and is inactive.

I'll also remove the webhook.

cc @sttts @munnerz @lilic
/assign @cblecker @spiffxp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikhita nikhita deleted the remove-client-go-unofficial-docs branch June 4, 2019 14:21
@nikhita
Copy link
Member Author

nikhita commented Jun 4, 2019

Webhooks removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants