-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the corresponding aks-engine version to latest (on 2019-07-02) #13289
Conversation
Welcome @nilo19! |
Hi @nilo19. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Need to run |
470a1ac
to
b5dd654
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 33c40c559d65a825275a099591ae59c569836ba2
|
cc |
wonder if I can do this here? (guess not) /test pull-kubernetes-e2e-aks-engine-azure |
nit: pull-kubernetes-e2e-aks-engine-azure only works on kubernetes repo. |
I'm not in k/org yet so I may not have permission? I thought if the PR was ok-to-test it should work if it's enabled, though. Unless you mean it's not supposed to work, in which case, oh 😄 |
It's not supposed to work in this repo. The test is only setup for kubernetes/kubernetes repo. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, fejta, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@nilo19: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@fejta thanks |
Update the version of aks-engine for kubernetes/kubernetes#79597