Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making k/r verify job required #13296

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Making k/r verify job required #13296

merged 1 commit into from
Jul 2, 2019

Conversation

pswica
Copy link
Contributor

@pswica pswica commented Jul 2, 2019

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 2, 2019
@justaugustus
Copy link
Member

/test pull-test-infra-bazel

@cpanato
Copy link
Member

cpanato commented Jul 2, 2019 •
edited
Loading

internet it down in cloudfare, maybe this is the reason for failing this now :)

Error downloading [https://mirror.bazel.build/nodejs.org/dist/v10.13.0/node-v10.13.0-linux-x64.tar.xz, https://nodejs.org/dist/v10.13.0/node-v10.13.0-linux-x64.tar.xz] to /bazel-scratch/.cache/bazel/_bazel_root/05618a594cb3499a4b912817865867cd/external/nodejs/bin/nodejs/node-v10.13.0-linux-x64.tar.xz: All mirrors are down: [GET returned 404 Not Found, Read timed out]

@pswica
Copy link
Contributor Author

pswica commented Jul 2, 2019

internet it down in cloudfare, maybe this is the reason for failing this now :)

Error downloading [https://mirror.bazel.build/nodejs.org/dist/v10.13.0/node-v10.13.0-linux-x64.tar.xz, https://nodejs.org/dist/v10.13.0/node-v10.13.0-linux-x64.tar.xz] to /bazel-scratch/.cache/bazel/_bazel_root/05618a594cb3499a4b912817865867cd/external/nodejs/bin/nodejs/node-v10.13.0-linux-x64.tar.xz: All mirrors are down: [GET returned 404 Not Found, Read timed out]

Good catch

@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3c1bd2ee7b47b1a4e7597590860605cafb391e64

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, pswica

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2019
@cpanato
Copy link
Member

cpanato commented Jul 2, 2019

/test pull-test-infra-bazel

@k8s-ci-robot k8s-ci-robot merged commit 1b4bd85 into kubernetes:master Jul 2, 2019
@k8s-ci-robot
Copy link
Contributor

@pswica: Updated the job-config configmap in namespace default using the following files:

  • key release-config.yaml using file config/jobs/kubernetes/release/release-config.yaml

In response to this:

cc @justaugustus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus Awaiting requested review from justaugustus

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pswica @justaugustus @cpanato @k8s-ci-robot