Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel check resource leak config. #13596

Merged

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Jul 25, 2019

The check-leaked-resources will invoke ./cluster/gce/list-resources.sh and the environment variables required are not obtained. To prevent it from failure, it should be cancelled.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @nilo19. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 25, 2019
@nilo19
Copy link
Member Author

nilo19 commented Jul 25, 2019

/sig azure

@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 25, 2019
@nilo19 nilo19 force-pushed the t-qini-unable-check-resource-leak-config branch from 40be18d to 6bd020f Compare July 25, 2019 03:20
@nilo19 nilo19 force-pushed the t-qini-unable-check-resource-leak-config branch from 6bd020f to 7ccd69a Compare July 25, 2019 03:21
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 25, 2019
@feiskyer
Copy link
Member

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4656761df2ad2638b42aaa989e63d425a55c078a

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit fb0d652 into kubernetes:master Jul 25, 2019
@k8s-ci-robot
Copy link
Contributor

@nilo19: Updated the job-config configmap in namespace default using the following files:

  • key cloud-provider-azure-config.yaml using file config/jobs/kubernetes/cloud-provider-azure/cloud-provider-azure-config.yaml

In response to this:

The check-leaked-resources will invoke ./cluster/gce/list-resources.sh and the environment variables required are not obtained. To prevent it from failure, it should be cancelled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nilo19 nilo19 deleted the t-qini-unable-check-resource-leak-config branch August 17, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants