Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinct release bucket for federation ci jobs #146

Merged
merged 1 commit into from
Jun 13, 2016

Conversation

colhom
Copy link
Contributor

@colhom colhom commented Jun 12, 2016

@colhom colhom changed the title Distinct release bucket for federation jobs Distinct release bucket for federation ci jobs Jun 12, 2016
@colhom
Copy link
Contributor Author

colhom commented Jun 12, 2016

It seems that the build system will take care of creating the bucket. https://github.com/kubernetes/kubernetes/blob/master/build/common.sh#L1102

@nikhiljindal
Copy link
Contributor

I dont know much about this code, but it LGTM.

@spxtr ?

@ghost
Copy link

ghost commented Jun 13, 2016

@fejta @ixdy @kubernetes/sig-testing Could you please help me to get this PR merged ASAP. I don't seem to have the permissions required to assign/label etc within this test-infra repo.

It is blocking e2e testing of Cluster Federation, which is in turn blocking the launch of v1.3. It resulted from a PR that merged late on Friday afternoon.

For further details see:

kubernetes/kubernetes#27236

Thanks!

cc: @nikhiljindal @madhusudancs @mml @matchstick FYI

@eparis
Copy link
Contributor

eparis commented Jun 13, 2016

@quinton-hoole try again, see what perms you have...

@colhom
Copy link
Contributor Author

colhom commented Jun 13, 2016

thanks @quinton-hoole for moving this one along! I still have no idea how we survived this long using the same bucket as "regular" kubernetes e2e...

@ghost
Copy link

ghost commented Jun 13, 2016

LGTM

@ghost ghost added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2016
@ghost ghost self-assigned this Jun 13, 2016
@ghost
Copy link

ghost commented Jun 13, 2016

Thanks @eparis that did the trick.

@eparis
Copy link
Contributor

eparis commented Jun 13, 2016

I'm not sure if anyone actually uses the labels though... I could be wrong... I think most people click the big green button...

@ghost
Copy link

ghost commented Jun 13, 2016

@eparis How do I make sure that this gets merged? There is no 1.3 milestone in this repo. Will merge-bot merge it automatically? If not, how do you suggest that we proceed?

@eparis
Copy link
Contributor

eparis commented Jun 13, 2016

I'm not over here much, so we'll have to wait on people like @fejta or @ixdy or @spxtr to say what the norm is...

(The bot definitely isn't listening here)

@ghost
Copy link

ghost commented Jun 13, 2016

@eparis Aah, OK. Would a test-infra team member like to LGTM and push the big green button for me please? @fejta @ixdy @spxtr any help appreciated.

@spxtr spxtr merged commit ec295d6 into kubernetes:master Jun 13, 2016
@spxtr
Copy link
Contributor

spxtr commented Jun 13, 2016

You should have the ability to push the big green button when travis is green @quinton-hoole.

I'm considering just making kubernetes-maintainers have write permission over here too so I don't need to add people, but at the same time I like keeping them separate.

@colhom colhom deleted the federation-release-bucket branch June 13, 2016 18:25
@ghost
Copy link

ghost commented Jun 13, 2016

Thanks @spxtr. Yes, I do have the permissions required to push the big green button. I just wanted to make sure that test-infra were happy with me performing a manual merge against this repo.

@eparis
Copy link
Contributor

eparis commented Jun 13, 2016

@quinton-hoole everything outside the main repo is the 'wild wild west'

@fejta
Copy link
Contributor

fejta commented Jun 13, 2016

Thanks for checking @quinton-hoole !

mborsz pushed a commit to mborsz/test-infra that referenced this pull request Dec 14, 2018
Mention feedback loop as future enhancement of Cluster Loader
MushuEE pushed a commit to MushuEE/test-infra that referenced this pull request Mar 17, 2022
Functions for reading and parsing discovery documents
are moved to the "discovery" package and functions
for converting between formats are moved to the
"conversions" package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Federation e2e failure: wrong ci build version
6 participants