New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds k8s-staging-e2e-test-images image pushing prow config #14833
adds k8s-staging-e2e-test-images image pushing prow config #14833
Conversation
Welcome @BCLAU! |
This looks mostly fine, though see my comment on kubernetes/kubernetes#84058. I'd also like to see a |
ca3bad6
to
962f4d6
Compare
Done |
/milestone v1.17 Adding to milestone 1.17, as suggested in kubernetes/kubernetes#81170 (comment) |
I am happy with this, but am going to hold off approval until its dependencies land for security reasons. /lgtm |
@Katharine @BCLAU @cjwagner Please don't forget that we are about to go into code freeze (14 November), if you want to get this through on time! |
/milestone v1.18 (Code freeze v1.17) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
Adds the prow config needed for pushing Kubernetes E2E images to a staging registry, from where the images will be pushed to the regular E2E test image registry.
962f4d6
to
07bc4b0
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjwagner, claudiubelu, fejta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks like kubernetes/kubernetes#84058 needs to merge first. |
The other PRs merged: kubernetes/kubernetes#84058 and kubernetes/k8s.io#400 . All of the other bits have also been taken care of. This is the last PR to kickstart the Image Promoter onto the k/k test images. Let's get this in. :) |
/hold cancel |
@claudiubelu: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Adds the prow config needed for pushing Kubernetes E2E images to a staging registry, from where the images will be pushed to the regular E2E test image registry.