Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds k8s-staging-e2e-test-images image pushing prow config #14833

Merged

Conversation

claudiubelu
Copy link
Contributor

Adds the prow config needed for pushing Kubernetes E2E images to a staging registry, from where the images will be pushed to the regular E2E test image registry.

@k8s-ci-robot
Copy link
Contributor

Welcome @BCLAU!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@Katharine
Copy link
Member

This looks mostly fine, though see my comment on kubernetes/kubernetes#84058.

I'd also like to see a run_if_changed regex here to constrain when this runs so we don't build on every Kubernetes merge, if there is any such constraint that makes sense.

@claudiubelu claudiubelu force-pushed the k8s-staging-e2e-test-images-job branch from ca3bad6 to 962f4d6 Compare October 28, 2019 17:56
@claudiubelu
Copy link
Contributor Author

This looks mostly fine, though see my comment on kubernetes/kubernetes#84058.

I'd also like to see a run_if_changed regex here to constrain when this runs so we don't build on every Kubernetes merge, if there is any such constraint that makes sense.

Done

@smourapina
Copy link

/milestone v1.17

Adding to milestone 1.17, as suggested in kubernetes/kubernetes#81170 (comment)

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 30, 2019
@Katharine
Copy link
Member

I am happy with this, but am going to hold off approval until its dependencies land for security reasons.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2019
@smourapina
Copy link

smourapina commented Nov 13, 2019

@Katharine @BCLAU @cjwagner Please don't forget that we are about to go into code freeze (14 November), if you want to get this through on time!

@smourapina
Copy link

/milestone v1.18

(Code freeze v1.17)

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.17, v1.18 Nov 15, 2019
@dims
Copy link
Member

dims commented Dec 13, 2019

/assign @fejta @spiffxp

Can we please get this in? will help us iterate towards build/push images automatically

Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 14, 2019
Adds the prow config needed for pushing Kubernetes E2E images to
a staging registry, from where the images will be pushed to the regular
E2E test image registry.
@claudiubelu claudiubelu force-pushed the k8s-staging-e2e-test-images-job branch from 962f4d6 to 07bc4b0 Compare December 16, 2019 12:41
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, claudiubelu, fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cjwagner
Copy link
Member

Looks like kubernetes/kubernetes#84058 needs to merge first.

@claudiubelu
Copy link
Contributor Author

The other PRs merged: kubernetes/kubernetes#84058 and kubernetes/k8s.io#400 . All of the other bits have also been taken care of. This is the last PR to kickstart the Image Promoter onto the k/k test images. Let's get this in. :)

@spiffxp
Copy link
Member

spiffxp commented Jan 10, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit bd332d3 into kubernetes:master Jan 10, 2020
@k8s-ci-robot
Copy link
Contributor

@claudiubelu: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key k8s-staging-e2e-test-images.yaml using file config/jobs/image-pushing/k8s-staging-e2e-test-images.yaml

In response to this:

Adds the prow config needed for pushing Kubernetes E2E images to a staging registry, from where the images will be pushed to the regular E2E test image registry.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants